mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Shiyan <shc_work@mail.ru>
To: barebox@lists.infradead.org
Subject: [PATCH] mfd: mc13xxx: VGEN1 and VGEN2 voltage bits positioned in "Regulator Setting 0" register
Date: Wed, 29 Jun 2016 19:26:02 +0300	[thread overview]
Message-ID: <1467217562-16048-1-git-send-email-shc_work@mail.ru> (raw)

The bits VGEN10-11 and VGEN20-22 is positioned in the Regulator Setting 0
register. This patch fixes these definitions and board (Efika MX), which
uses this voltages.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 arch/arm/boards/efika-mx-smartbook/board.c |  8 +++++---
 include/mfd/mc13892.h                      | 28 ++++++++++++++--------------
 2 files changed, 19 insertions(+), 17 deletions(-)

diff --git a/arch/arm/boards/efika-mx-smartbook/board.c b/arch/arm/boards/efika-mx-smartbook/board.c
index d1d020e..d7c11dc 100644
--- a/arch/arm/boards/efika-mx-smartbook/board.c
+++ b/arch/arm/boards/efika-mx-smartbook/board.c
@@ -122,9 +122,13 @@ static void efikamx_power_init(struct mc13xxx *mc)
 	/* Set VDIG to 1.8V, VGEN3 to 1.8V, VCAM to 2.6V */
 	mc13xxx_reg_read(mc, MC13892_REG_SETTING_0, &val);
 	val &= ~(MC13892_SETTING_0_VCAM_MASK |
+		MC13892_SETTING_0_VGEN1_MASK |
+		MC13892_SETTING_0_VGEN2_MASK |
 		MC13892_SETTING_0_VGEN3_MASK |
 		MC13892_SETTING_0_VDIG_MASK);
 	val |= MC13892_SETTING_0_VDIG_1_8 |
+		MC13892_SETTING_0_VGEN1_1_2 |
+		MC13892_SETTING_0_VGEN2_3_15 |
 		MC13892_SETTING_0_VGEN3_1_8 |
 		MC13892_SETTING_0_VCAM_2_6;
 	mc13xxx_reg_write(mc, MC13892_REG_SETTING_0, val);
@@ -136,9 +140,7 @@ static void efikamx_power_init(struct mc13xxx *mc)
 			MC13892_SETTING_1_VAUDIO_MASK);
 	val |= MC13892_SETTING_1_VSD_3_15 |
 		MC13892_SETTING_1_VAUDIO_3_0 |
-		MC13892_SETTING_1_VVIDEO_2_775 |
-		MC13892_SETTING_1_VGEN1_1_2 |
-		MC13892_SETTING_1_VGEN2_3_15;
+		MC13892_SETTING_1_VVIDEO_2_775;
 	mc13xxx_reg_write(mc, MC13892_REG_SETTING_1, val);
 
 	/* Enable VGEN1, VGEN2, VDIG, VPLL */
diff --git a/include/mfd/mc13892.h b/include/mfd/mc13892.h
index 22df5f0..c92a462 100644
--- a/include/mfd/mc13892.h
+++ b/include/mfd/mc13892.h
@@ -95,22 +95,22 @@
 #define MC13892_SETTING_1_VSD_3_0	(6 << 6)
 #define MC13892_SETTING_1_VSD_3_15	(7 << 6)
 #define MC13892_SETTING_1_VSD_MASK	(7 << 6)
-#define MC13892_SETTING_1_VGEN1_1_2	0
-#define MC13892_SETTING_1_VGEN1_1_5	1
-#define MC13892_SETTING_1_VGEN1_2_775	2
-#define MC13892_SETTING_1_VGEN1_3_15	3
-#define MC13892_SETTING_1_VGEN1_MASK	3
-#define MC13892_SETTING_1_VGEN2_1_2	(0 << 6)
-#define MC13892_SETTING_1_VGEN2_1_5	(1 << 6)
-#define MC13892_SETTING_1_VGEN2_1_6	(2 << 6)
-#define MC13892_SETTING_1_VGEN2_1_8	(3 << 6)
-#define MC13892_SETTING_1_VGEN2_2_7	(4 << 6)
-#define MC13892_SETTING_1_VGEN2_2_8	(5 << 6)
-#define MC13892_SETTING_1_VGEN2_3_0	(6 << 6)
-#define MC13892_SETTING_1_VGEN2_3_15	(7 << 6)
-#define MC13892_SETTING_1_VGEN2_MASK	(7 << 6)
 
 /* Fields in REG_SETTING_0 */
+#define MC13892_SETTING_0_VGEN1_1_2	(0 << 0)
+#define MC13892_SETTING_0_VGEN1_1_5	(1 << 0)
+#define MC13892_SETTING_0_VGEN1_2_775	(2 << 0)
+#define MC13892_SETTING_0_VGEN1_3_15	(3 << 0)
+#define MC13892_SETTING_0_VGEN1_MASK	(3 << 0)
+#define MC13892_SETTING_0_VGEN2_1_2	(0 << 6)
+#define MC13892_SETTING_0_VGEN2_1_5	(1 << 6)
+#define MC13892_SETTING_0_VGEN2_1_6	(2 << 6)
+#define MC13892_SETTING_0_VGEN2_1_8	(3 << 6)
+#define MC13892_SETTING_0_VGEN2_2_7	(4 << 6)
+#define MC13892_SETTING_0_VGEN2_2_8	(5 << 6)
+#define MC13892_SETTING_0_VGEN2_3_0	(6 << 6)
+#define MC13892_SETTING_0_VGEN2_3_15	(7 << 6)
+#define MC13892_SETTING_0_VGEN2_MASK	(7 << 6)
 #define MC13892_SETTING_0_VGEN3_1_8	(0 << 14)
 #define MC13892_SETTING_0_VGEN3_2_9	(1 << 14)
 #define MC13892_SETTING_0_VGEN3_MASK	(1 << 14)
-- 
2.4.9


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2016-06-29 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29 16:26 Alexander Shiyan [this message]
2016-06-30  6:42 ` Sascha Hauer
2016-06-30  7:02   ` Alexander Shiyan
2016-07-07  7:49 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467217562-16048-1-git-send-email-shc_work@mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox