Re: [PATCH 5/5] scripts: imx-usb-loader: split off topic-code into functions

From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Alexander Kurz" <akurz@blala.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/5] scripts: imx-usb-loader: split off topic-code into functions
Date: Sun, 17 Jul 2016 19:19:14 +0300	[thread overview]
Message-ID: <1468772354.967026288@f191.i.mail.ru> (raw)
In-Reply-To: <1468770798-22102-5-git-send-email-akurz@blala.de>

>Воскресенье, 17 июля 2016, 18:53 +03:00 от Alexander Kurz <akurz@blala.de>:
>
>Improve code understandability: extract the "jump application" Serial
>Download Protocol access method and file-to-buffer reader functionality
>out of do_irom_download().
>
>Signed-off-by: Alexander Kurz < akurz@blala.de >
>---
> scripts/imx/imx-usb-loader.c | 159 +++++++++++++++++++++++++------------------
> 1 file changed, 92 insertions(+), 67 deletions(-)
>
>diff --git a/scripts/imx/imx-usb-loader.c b/scripts/imx/imx-usb-loader.c
...
>+FILE *xfile;
>+unsigned fsize;
>+int cnt;
>+unsigned char *buf;
>+xfile = fopen(name, "rb");
>+if (!xfile) {
>+printf("error, can not open input file: %s\n", name);
>+return -5;
...
>+fsize = get_file_size(xfile);
>+if (fsize < 0x20) {
>+printf("error, file: %s is too small\n", name);
>+fclose(xfile);
>+return -2;
-2 ? Maybe -EINVAL or so will be more appropriate here?

---

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox