From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH v2 2/7] mfd: syscon: Don't call request_iomem_region()
Date: Mon, 18 Jul 2016 08:14:44 -0700 [thread overview]
Message-ID: <1468854889-6057-2-git-send-email-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <1468854889-6057-1-git-send-email-andrew.smirnov@gmail.com>
On platforms that mix dedicated IP block register space with
miscellaneous registers it is necessary to share register window between
syscon and dedicated IP block driver. Calling request_iomem_region()
implies exclusive ownership of the region, which, in the case above
could not happen.
This change also makes this driver's behaviour to that of its Linux
kernel counterpart.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/mfd/syscon.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index 9589a03..ac46122 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c
@@ -76,12 +76,6 @@ static int syscon_probe(struct device_d *dev)
return PTR_ERR(res);
}
- res = request_iomem_region(dev_name(dev), res->start, res->end);
- if (IS_ERR(res)) {
- free(syscon);
- return PTR_ERR(res);
- }
-
syscon->base = (void __iomem *)res->start;
dev->priv = syscon;
--
2.5.5
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-07-18 15:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 15:14 [PATCH v2 1/7] Revert "syscon: Decrease driver registration priority" Andrey Smirnov
2016-07-18 15:14 ` Andrey Smirnov [this message]
2016-07-18 15:14 ` [PATCH v2 3/7] mfd: syscon: Decouple syscon interface from platform devices Andrey Smirnov
2016-07-18 15:14 ` [PATCH v2 4/7] mfd: syscon: Don't check xzalloc return for NULL Andrey Smirnov
2016-07-18 15:14 ` [PATCH v2 5/7] mfd: syscon: Use IOMEM instead of explicit cast Andrey Smirnov
2016-07-18 15:14 ` [PATCH v2 6/7] imx_thermal: Remove leftover debug output Andrey Smirnov
2016-07-18 15:14 ` [PATCH v2 7/7] i.MX: ocotp: Register regmap against orignal device Andrey Smirnov
2016-07-19 4:51 ` [PATCH v2 1/7] Revert "syscon: Decrease driver registration priority" Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468854889-6057-2-git-send-email-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox