From: Lucas Stach <l.stach@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: imx6: reset PLL2's PFD2 on i.MX6D
Date: Wed, 14 Sep 2016 13:05:23 +0200 [thread overview]
Message-ID: <1473851123.2243.54.camel@pengutronix.de> (raw)
In-Reply-To: <1473846672.2243.39.camel@pengutronix.de>
Am Mittwoch, den 14.09.2016, 11:51 +0200 schrieb Lucas Stach:
> Am Mittwoch, den 14.09.2016, 09:56 +0200 schrieb Uwe Kleine-König:
> > The check for is_imx6q was introduced initially in
> >
> > f1f6d76370b3 ("ARM: i.MX6: correct work flow of PFDs from uboot-sources")
> >
> > to differentiate between i.MX6DL+i.MX6SL and i.MX6Q. The i.MX6D must be
> > handled like the latter, so drop the check. i.MX6DL+i.MX6SL can be
> > ignored here since since
> >
> > a66596282413 ("imx6: lowlevel_init: Fix workaround for new i.MX6s chips")
> >
> > the PFD handling is only done for i.MX6DQ.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > arch/arm/mach-imx/imx6.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-imx/imx6.c b/arch/arm/mach-imx/imx6.c
> > index ba8fb8964ac8..4391839a0b7e 100644
> > --- a/arch/arm/mach-imx/imx6.c
> > +++ b/arch/arm/mach-imx/imx6.c
> > @@ -77,7 +77,7 @@ void imx6_init_lowlevel(void)
>
> The comment right above this code block isn't reflecting reality anymore
> after this change. Please fix it up.
FTR: Please, disregard my comment. It's wrong and this patch is just
fine.
>
> > BM_ANADIG_PFD_480_PFD0_CLKGATE,
> > MX6_ANATOP_BASE_ADDR + HW_ANADIG_PFD_480_SET);
> > writel(BM_ANADIG_PFD_528_PFD3_CLKGATE |
> > - (is_imx6q ? BM_ANADIG_PFD_528_PFD2_CLKGATE : 0) |
> > + BM_ANADIG_PFD_528_PFD2_CLKGATE |
> > BM_ANADIG_PFD_528_PFD1_CLKGATE |
> > BM_ANADIG_PFD_528_PFD0_CLKGATE,
> > MX6_ANATOP_BASE_ADDR + HW_ANADIG_PFD_528_SET);
> > @@ -88,7 +88,7 @@ void imx6_init_lowlevel(void)
> > BM_ANADIG_PFD_480_PFD0_CLKGATE,
> > MX6_ANATOP_BASE_ADDR + HW_ANADIG_PFD_480_CLR);
> > writel(BM_ANADIG_PFD_528_PFD3_CLKGATE |
> > - (is_imx6q ? BM_ANADIG_PFD_528_PFD2_CLKGATE : 0) |
> > + BM_ANADIG_PFD_528_PFD2_CLKGATE |
> > BM_ANADIG_PFD_528_PFD1_CLKGATE |
> > BM_ANADIG_PFD_528_PFD0_CLKGATE,
> > MX6_ANATOP_BASE_ADDR + HW_ANADIG_PFD_528_CLR);
>
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-09-14 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 7:56 Uwe Kleine-König
2016-09-14 9:51 ` Lucas Stach
2016-09-14 10:17 ` [PATCH v2] " Uwe Kleine-König
2016-09-15 8:01 ` Sascha Hauer
2016-09-14 11:05 ` Lucas Stach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473851123.2243.54.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox