From: Trent Piepho <tpiepho@kymetacorp.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] pbl: console: Make it work with multiple setup_c()
Date: Wed, 14 Sep 2016 17:41:06 +0000 [thread overview]
Message-ID: <1473875075.4359.7.camel@rtred1test09.kymeta.local> (raw)
In-Reply-To: <1473841290-3935-1-git-send-email-s.hauer@pengutronix.de>
On Wed, 2016-09-14 at 10:21 +0200, Sascha Hauer wrote:
> +
> +static void (*__putc)(void *ctx, int c) = INVALID_PTR;
> +static void *putc_ctx = INVALID_PTR;
There's also __attribute__ ((section(".data"))). U-boot uses that. It
does make it clear why INVALID_PTR is not NULL.
Also, could use ERR_PTR(-EINVAL).
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-09-14 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 8:21 Sascha Hauer
2016-09-14 8:21 ` [PATCH 2/2] ARM: i.MX6: Sabrelite: Add PBL console support Sascha Hauer
2016-09-14 17:41 ` Trent Piepho [this message]
2016-09-15 7:25 ` [PATCH 1/2] pbl: console: Make it work with multiple setup_c() Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473875075.4359.7.camel@rtred1test09.kymeta.local \
--to=tpiepho@kymetacorp.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox