From: Trent Piepho <tpiepho@kymetacorp.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH v3 3/3] ARM: socfpga: dtsi: add dw-wdt reset lines
Date: Wed, 26 Oct 2016 20:12:07 +0000 [thread overview]
Message-ID: <1477512729.14501.14.camel@rtred1test09.kymeta.local> (raw)
In-Reply-To: <20161017075052.30802-3-s.trumtrar@pengutronix.de>
On Mon, 2016-10-17 at 09:50 +0200, Steffen Trumtrar wrote:
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> arch/arm/dts/socfpga.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/dts/socfpga.dtsi b/arch/arm/dts/socfpga.dtsi
> index d16758fdab46..66d7f21dc6a3 100644
> --- a/arch/arm/dts/socfpga.dtsi
> +++ b/arch/arm/dts/socfpga.dtsi
> @@ -49,3 +49,13 @@
> &f2s_sdram_ref_clk {
> clock-frequency = <0>;
> };
> +
> +&watchdog0 {
> + resets = <&rst L4WD0_RESET>;
> + reset-names = "dw-wdt";
This is the official binding? The reset-names property is supposed to
be the name of the reset from the perspective of the device being
described, e.g. the watchdog. Not the name from the perspective of the
reset controller. Rather than "dw-wdt", the name should something like
"reset", which clearly doesn't add much information, which is why the
reset-names property is supposed to be optional.
> +};
> +
> +&watchdog1 {
> + resets = <&rst L4WD1_RESET>;
> + reset-names = "dw-wdt";
> +};
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-10-26 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 7:50 [PATCH v3 1/3] reset: import socfpga-reset driver from linux Steffen Trumtrar
2016-10-17 7:50 ` [PATCH v3 2/3] watchdog: add designware driver Steffen Trumtrar
2016-11-14 15:14 ` Sascha Hauer
2016-10-17 7:50 ` [PATCH v3 3/3] ARM: socfpga: dtsi: add dw-wdt reset lines Steffen Trumtrar
2016-10-26 20:12 ` Trent Piepho [this message]
2016-10-27 6:58 ` Steffen Trumtrar
2016-10-28 7:20 ` Sascha Hauer
2016-10-18 5:39 ` [PATCH v3 1/3] reset: import socfpga-reset driver from linux Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477512729.14501.14.camel@rtred1test09.kymeta.local \
--to=tpiepho@kymetacorp.com \
--cc=barebox@lists.infradead.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox