From: Stefan Lengfeld <s.lengfeld@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCH upstream 3/4] state: fix state is not saved when string variable is changed
Date: Wed, 2 Nov 2016 08:54:29 +0100 [thread overview]
Message-ID: <1478073270-3527-3-git-send-email-s.lengfeld@phytec.de> (raw)
In-Reply-To: <1478073270-3527-1-git-send-email-s.lengfeld@phytec.de>
The dirty flag was not set properly.
Signed-off-by: Stefan Lengfeld <s.lengfeld@phytec.de>
---
common/state/state_variables.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/state/state_variables.c b/common/state/state_variables.c
index 1e37856..fd072a0 100644
--- a/common/state/state_variables.c
+++ b/common/state/state_variables.c
@@ -383,7 +383,7 @@ static int state_string_set(struct param_d *p, void *priv)
if (ret)
return ret;
- return state_set_dirty(p, sv->state);
+ return state_set_dirty(p, sv);
}
static int state_string_get(struct param_d *p, void *priv)
--
1.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-11-02 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 7:54 [PATCH upstream 1/4] state: use packet attribute for on storage structs Stefan Lengfeld
2016-11-02 7:54 ` [PATCH upstream 2/4] state: fix indentation Stefan Lengfeld
2016-11-02 7:54 ` Stefan Lengfeld [this message]
2016-11-02 7:54 ` [PATCH upstream 4/4] docs: state: make string variable type clearer Stefan Lengfeld
2016-11-02 14:17 ` [PATCH upstream 1/4] state: use packet attribute for on storage structs Andrey Smirnov
2016-11-03 6:21 ` Sascha Hauer
2016-11-03 8:38 ` Stefan Lengfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478073270-3527-3-git-send-email-s.lengfeld@phytec.de \
--to=s.lengfeld@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox