Re: [PATCH 2/5] efi: fix lds for secure boot support

[Lucas Stach <l.stach@pengutronix.de>]

Am Freitag, den 10.03.2017, 14:54 +0100 schrieb Jean-Christophe
PLAGNIOL-VILLARD:
> On 12:05 Fri 10 Mar     , Lucas Stach wrote:
> > Am Freitag, den 10.03.2017, 18:17 +0800 schrieb Jean-Christophe
> > PLAGNIOL-VILLARD:
> > > > On Mar 10, 2017, at 1:24 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > > > 
> > > > Am Donnerstag, den 09.03.2017, 15:34 +0100 schrieb Jean-Christophe
> > > > PLAGNIOL-VILLARD:
> > > >> everythink need to be aligned to 4096
> > > > 
> > > > Why? The commit message isn't really telling anything.
> > > This is a requierment by EFI
> > 
> > This is in no way an EFI requirement.
> > 
> > Googling tells me that the signing procedure for EFI secure boot is
> > built around a PE binary. PE in turn is based on the COFF binary format
> > which, unlike ELF, has no section descriptions in the header and
> > therefore requires the sections to be placed page aligned (4K on x86, 4K
> > or 64K on ARM64).
> No COFF does not require to have section "page aligned" which is wrong here
> The is a Requirement by EFI from secure boot
> 
> Otherwise EFI will not work today
> 
> > 
> > All of the above is what should have been included in the commit
> > message, to allow other people to understand the commit and not require
> > them to google their way to the justification of this commit.
> And read the Spec is required to undrestant EFI no?
> Or I need to put the spec in the commit too?
> 
At least a pointer to the relevant part of the spec would be
appreciated.

That we are even having this conversation shows that your commit
messages are a bit too terse. Being a bit more verbose would be really
helpful for other folks trying to understand your changes.

Thanks,
Lucas


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox