[PATCH] openrisc: fix call to restart_handler_register_fn

[PATCH] openrisc: fix call to restart_handler_register_fn

[Franck Jullien]

Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
---
 arch/openrisc/cpu/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/openrisc/cpu/cpu.c b/arch/openrisc/cpu/cpu.c
index d52b021..e7f9445 100644
--- a/arch/openrisc/cpu/cpu.c
+++ b/arch/openrisc/cpu/cpu.c
@@ -41,6 +41,6 @@ static void __noreturn openrisc_restart_cpu(struct restart_handler *rst)
 
 static int restart_register_feature(void)
 {
-	restart_handler_register_fn(openrisc_restart_cpu, NULL, RESET_SCOPE_CPU);
+	return restart_handler_register_fn(openrisc_restart_cpu);
 }
 coredevice_initcall(restart_register_feature);
-- 
2.7.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] openrisc: fix call to restart_handler_register_fn

[Sascha Hauer]

On Fri, Mar 24, 2017 at 08:35:22PM +0100, Franck Jullien wrote:
> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
> ---
>  arch/openrisc/cpu/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/openrisc/cpu/cpu.c b/arch/openrisc/cpu/cpu.c
> index d52b021..e7f9445 100644
> --- a/arch/openrisc/cpu/cpu.c
> +++ b/arch/openrisc/cpu/cpu.c
> @@ -41,6 +41,6 @@ static void __noreturn openrisc_restart_cpu(struct restart_handler *rst)
>  
>  static int restart_register_feature(void)
>  {
> -	restart_handler_register_fn(openrisc_restart_cpu, NULL, RESET_SCOPE_CPU);
> +	return restart_handler_register_fn(openrisc_restart_cpu);
>  }

Applied, thanks. It seems I have disabled my openrisc autobuild at some
point. Just re-enabled it. Normally such build failures shouldn't
happen.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] openrisc: fix call to restart_handler_register_fn

[Franck Jullien]

2017-03-29 8:42 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> On Fri, Mar 24, 2017 at 08:35:22PM +0100, Franck Jullien wrote:
>> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
>> ---
>>  arch/openrisc/cpu/cpu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/openrisc/cpu/cpu.c b/arch/openrisc/cpu/cpu.c
>> index d52b021..e7f9445 100644
>> --- a/arch/openrisc/cpu/cpu.c
>> +++ b/arch/openrisc/cpu/cpu.c
>> @@ -41,6 +41,6 @@ static void __noreturn openrisc_restart_cpu(struct restart_handler *rst)
>>
>>  static int restart_register_feature(void)
>>  {
>> -     restart_handler_register_fn(openrisc_restart_cpu, NULL, RESET_SCOPE_CPU);
>> +     return restart_handler_register_fn(openrisc_restart_cpu);
>>  }
>
> Applied, thanks. It seems I have disabled my openrisc autobuild at some
> point. Just re-enabled it. Normally such build failures shouldn't
> happen.
>

FYI, you can get the lastest toolchain here:

https://github.com/openrisc/or1k-gcc/releases/tag/or1k-5.4.0-20170218

Franck.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] openrisc: fix call to restart_handler_register_fn

[Sascha Hauer]

On Wed, Mar 29, 2017 at 03:45:04PM +0200, Franck Jullien wrote:
> 2017-03-29 8:42 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> > On Fri, Mar 24, 2017 at 08:35:22PM +0100, Franck Jullien wrote:
> >> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
> >> ---
> >>  arch/openrisc/cpu/cpu.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/openrisc/cpu/cpu.c b/arch/openrisc/cpu/cpu.c
> >> index d52b021..e7f9445 100644
> >> --- a/arch/openrisc/cpu/cpu.c
> >> +++ b/arch/openrisc/cpu/cpu.c
> >> @@ -41,6 +41,6 @@ static void __noreturn openrisc_restart_cpu(struct restart_handler *rst)
> >>
> >>  static int restart_register_feature(void)
> >>  {
> >> -     restart_handler_register_fn(openrisc_restart_cpu, NULL, RESET_SCOPE_CPU);
> >> +     return restart_handler_register_fn(openrisc_restart_cpu);
> >>  }
> >
> > Applied, thanks. It seems I have disabled my openrisc autobuild at some
> > point. Just re-enabled it. Normally such build failures shouldn't
> > happen.
> >
> 
> FYI, you can get the lastest toolchain here:
> 
> https://github.com/openrisc/or1k-gcc/releases/tag/or1k-5.4.0-20170218

Thanks for noting. I just updated my toolchain to the latest one. From a
quick test it seems to work.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox