mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: imx: phyCORE i.MX7 on phyBOARD-Zeta support
Date: Mon, 10 Jul 2017 17:42:37 +0200	[thread overview]
Message-ID: <1499701357.18894.1.camel@pengutronix.de> (raw)
In-Reply-To: <20170710152706.GA12108@ravnborg.org>

Am Montag, den 10.07.2017, 17:27 +0200 schrieb Sam Ravnborg:
> Hi Lucas
> 
> > index 000000000000..b1608dd9c730
> > --- /dev/null
> > +++ b/arch/arm/boards/phytec-phycore-imx7/flash-header-phytec-phycore-imx7.imxcfg
> > @@ -0,0 +1,76 @@
> > +/*
> > + * Copyright (C) 2016 NXP Semiconductors
> > + *
> > + * SPDX-License-Identifier:	GPL-2.0
> > + *
> > + * Refer docs/README.imxmage for more details about how-to configure
> > + * and create imximage boot image
> > + *
> > + * The syntax is taken as close as possible with the kwbimage
> > + */
> > +
> > +soc imx7
> > +loadaddr 0x80000000
> > +dcdofs 0x400
> > +
> > +wm 32 0x30340004 0x4F400005
> > +/* Clear then set bit30 to ensure exit from DDR retention */
> > +wm 32 0x30360388 0x40000000
> > +wm 32 0x30360384 0x40000000
> > +
> > +wm 32 0x30391000 0x00000002
> > +wm 32 0x307a0000 0x01040001
> 
> 
> Uwe posted a patch the other day to replace all these
> constants with defines across the tree.
> Looks like a step backward to introduce a new file where this approach is not used.

Uwes patch replaces raw values in the i.MX6 files (where we have defines
for the registers). This is a new i.MX7 board, where no such defines
exists for now.

I'm not saying that we shouldn't try to do the same thing for i.MX7, but
it is considerably more work than for MX6.

Regards,
Lucas


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-07-10 15:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10 15:21 Lucas Stach
2017-07-10 15:27 ` Sam Ravnborg
2017-07-10 15:42   ` Lucas Stach [this message]
2017-07-10 16:09     ` Sam Ravnborg
2017-07-10 15:33 ` Sam Ravnborg
2017-07-10 19:40 ` Stefan Lengfeld
2017-07-11  8:23   ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499701357.18894.1.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox