mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH] i.MX: clk-pllv3: Initially disable PLL_BYPASS bit
Date: Wed, 12 Jul 2017 10:56:08 +0200	[thread overview]
Message-ID: <1499849768.5060.32.camel@pengutronix.de> (raw)
In-Reply-To: <CAHQ1cqFqxy5WPcRtmeq5WSxNQqWdPBS_e901L9+yEp8NiKGG+w@mail.gmail.com>

Am Dienstag, den 11.07.2017, 12:41 -0500 schrieb Andrey Smirnov:
> On Tue, Jul 11, 2017 at 4:30 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> > Commit cbff8031b491 ("i.MX: clk-pllv3: Do not touch PLL_BYPASS bit")
> > overreached a bit by removing the code that disables the PLL_BYPASS bit
> > for all architectures instead of making an exception for Vybrid and
> > i.MX6SL. This causes the USB controller on i.MX6Q to run at bypass
> > frequency and fail:
> >
> >     barebox@Boundary Devices i.MX6 Quad Nitrogen6x Board:/ usb
> >     usb: USB: scanning bus for devices...
> >     usb: Bus 001 Device 001: ID 0000:0000 EHCI Host Controller
> >     imx-usb 2184200.usb: port(0) reset error
> >
> > Also, the linux clk-pllv3 driver never looks at or touches the
> > PLL_BYPASS bit, but expects the bootloader to set it up correctly.
> >
> 
> Hmm, wouldn't this code:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/imx/clk-imx6q.c?h=v4.12#n469
> 
> alter the state of BYPASS bit?
> 
> > This patch adds code to unconditionally disable the PLL_BYPASS bit
> > initially, when the PLL clocks are registered.
> >
> 
> The reason I didn't make that patch as a exception for Vybrid and
> i.MX6SL was because any other i.MX6 clock trees didn't reference that
> clock mux, so I incorrectly assumed it not to be present in the
> hardware. IMHO, if this is not the case, a better fix for this would
> be to change the clock tree to include PLL_BYPASS related mux and call
> clk_set_parent() explicitly.
> 
> And having looked at i.MX6Q clock tree code in the kerenel it seems
> like Barebox version got out of sync and kernel code does create such
> clock tree node, so maybe we should do that as well?

Possibly, but that's a bigger change than what I would like to pull into
master and probably a 2017.07 stable.

Also do we ever have a need to use the PLLs in bypass mode?

Regards,
Lucas


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-07-12  8:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11  9:30 Philipp Zabel
2017-07-11 17:41 ` Andrey Smirnov
2017-07-12  8:56   ` Lucas Stach [this message]
2017-07-12  9:52     ` Philipp Zabel
2017-07-12 10:13       ` Philipp Zabel
2017-07-12 14:56 ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499849768.5060.32.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox