From: Lucas Stach <l.stach@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1 2/2] serial: ns16550: provide big-endian support
Date: Mon, 31 Jul 2017 12:03:45 +0200 [thread overview]
Message-ID: <1501495425.2431.3.camel@pengutronix.de> (raw)
In-Reply-To: <20170727050055.14188-2-o.rempel@pengutronix.de>
Am Donnerstag, den 27.07.2017, 07:00 +0200 schrieb Oleksij Rempel:
> we need it at least for QCA AR9344
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/serial/serial_ns16550.c | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> index a8953cd99d..4d73ea8b87 100644
> --- a/drivers/serial/serial_ns16550.c
> +++ b/drivers/serial/serial_ns16550.c
> @@ -94,6 +94,16 @@ static void ns16550_write_reg_mmio_32(struct ns16550_priv *priv, uint8_t val, un
> writel(val, priv->mmiobase + offset);
> }
>
> +static uint8_t ns16550_read_reg_mmio_32be(struct ns16550_priv *priv, unsigned offset)
> +{
> + return ioread32be(priv->mmiobase + offset);
> +}
> +
> +static void ns16550_write_reg_mmio_32be(struct ns16550_priv *priv, uint8_t val, unsigned offset)
> +{
> + iowrite32be(val, priv->mmiobase + offset);
> +}
This doesn't work on PPC and x86, as those 2 architectures are missing
the "be" variants of the iowrite/ioread functions.
> +
> static uint8_t ns16550_read_reg_ioport_8(struct ns16550_priv *priv, unsigned offset)
> {
> return inb(priv->iobase + offset);
> @@ -305,8 +315,13 @@ static void ns16550_probe_dt(struct device_d *dev, struct ns16550_priv *priv)
> priv->write_reg = ns16550_write_reg_mmio_16;
> break;
> case 4:
> - priv->read_reg = ns16550_read_reg_mmio_32;
> - priv->write_reg = ns16550_write_reg_mmio_32;
> + if (of_device_is_big_endian(np)) {
> + priv->read_reg = ns16550_read_reg_mmio_32be;
> + priv->write_reg = ns16550_write_reg_mmio_32be;
> + } else {
> + priv->read_reg = ns16550_read_reg_mmio_32;
> + priv->write_reg = ns16550_write_reg_mmio_32;
> + }
> break;
> default:
> dev_err(dev, "unsupported reg-io-width (%d)\n",
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-07-31 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 5:00 [PATCH v1 1/2] of: base: port of_device_is_big_endian from linux Oleksij Rempel
2017-07-27 5:00 ` [PATCH v1 2/2] serial: ns16550: provide big-endian support Oleksij Rempel
2017-07-31 10:03 ` Lucas Stach [this message]
2017-08-01 10:55 ` Oleksij Rempel
2017-07-31 10:02 ` [PATCH v1 1/2] of: base: port of_device_is_big_endian from linux Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501495425.2431.3.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox