mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Roland Hieber <r.hieber@pengutronix.de>, barebox@lists.infradead.org
Cc: Alexander Dahl <post@lespocky.de>, Roland Hieber <rohieb@rohieb.name>
Subject: Re: [PATCH] ARM: dts: bcm2835-rpi: re-enable booting from SD card
Date: Wed, 06 Dec 2017 16:17:55 +0100	[thread overview]
Message-ID: <1512573475.6394.22.camel@pengutronix.de> (raw)
In-Reply-To: <20171206151233.29342-1-r.hieber@pengutronix.de>

Am Mittwoch, den 06.12.2017, 16:12 +0100 schrieb Roland Hieber:
> From: Roland Hieber <rohieb@rohieb.name>
> 
> Kernel commit a19adf8d86e822eba502486524127595372c85f6 [0] changed
> the
> RPi1 device tree from &sdhci to &sdhost, which was imported in
> barebox
> commit d14b844b08635c717fb52a294ed8d6872e260315. It seems that
> barebox
> does not have a driver for brcm,bcm2835-sdhost (yet), which resulted
> in
> barebox unable to boot from SD card. However, the driver for
> brcm,bcm2835-sdhci worked fine in the past.
> 
> Although the upstream change was made for good reasons, the simplest
> change for barebox for now is to revert to using &sdhci and disable
> &sdhost.
> 
> Thanks to Alexander Dahl for raising this issue on the DistroKit
> mailing list!
> 
> [0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g
> it/commit/?id=a19adf8d86e822eba502486524127595372c85f6
> 
> Cc: Alexander Dahl <post@lespocky.de>
> Signed-off-by: Roland Hieber <rohieb@rohieb.name>
> ---
>  arch/arm/dts/bcm2835-rpi.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/dts/bcm2835-rpi.dts b/arch/arm/dts/bcm2835-
> rpi.dts
> index 0095f58a3c..ab2d6dff64 100644
> --- a/arch/arm/dts/bcm2835-rpi.dts
> +++ b/arch/arm/dts/bcm2835-rpi.dts
> @@ -9,3 +9,10 @@
>  		reg = <0x0 0x0>;
>  	};
>  };

Missing newline here. Other than that:

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> +&sdhci {
> +	status = "okay";
> +};
> +
> +&sdhost {
> +	status = "disabled";
> +};

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2017-12-06 15:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 15:12 Roland Hieber
2017-12-06 15:17 ` Lucas Stach [this message]
2017-12-06 16:06 ` Alexander Dahl
2017-12-07 15:19 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512573475.6394.22.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=post@lespocky.de \
    --cc=r.hieber@pengutronix.de \
    --cc=rohieb@rohieb.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox