[PATCH] spi: imx: make xchg_single timeout value compatible for older boards

[PATCH] spi: imx: make xchg_single timeout value compatible for older boards

[Alexander Kurz]

A call of xchg_single will issue the transfer of 24 data bits with a given
maximum frequency. Since there exist some i.MX based boards with
spi-max-frequency = <100000>, change the xchg_single timeout to still
support those boards.

Fixes: 1439cdf7c6fc ("spi: imx: add timeout to xchg_single")
Signed-off-by: Alexander Kurz <akurz@blala.de>
---
 drivers/spi/imx_spi.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/imx_spi.c b/drivers/spi/imx_spi.c
index 7819879..0827de7 100644
--- a/drivers/spi/imx_spi.c
+++ b/drivers/spi/imx_spi.c
@@ -32,8 +32,11 @@
 #include <linux/err.h>
 #include <clock.h>
 
-/* time to wait for STAT_RR getting set */
-#define IMX_SPI_RR_TIMEOUT	10000 /* ns */
+/*
+ * time to wait for STAT_RR getting set, should allow the transfer
+ * of 24 bits at spi-max-frequency of 100kHz
+ */
+#define IMX_SPI_RR_TIMEOUT	250000 /* ns */
 
 struct imx_spi {
 	struct spi_master	master;
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] spi: imx: make xchg_single timeout value compatible for older boards

[Sascha Hauer]

On Thu, Dec 14, 2017 at 09:55:54AM +0100, Alexander Kurz wrote:
> A call of xchg_single will issue the transfer of 24 data bits with a given
> maximum frequency. Since there exist some i.MX based boards with
> spi-max-frequency = <100000>, change the xchg_single timeout to still
> support those boards.
> 
> Fixes: 1439cdf7c6fc ("spi: imx: add timeout to xchg_single")
> Signed-off-by: Alexander Kurz <akurz@blala.de>
> ---
>  drivers/spi/imx_spi.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/spi/imx_spi.c b/drivers/spi/imx_spi.c
> index 7819879..0827de7 100644
> --- a/drivers/spi/imx_spi.c
> +++ b/drivers/spi/imx_spi.c
> @@ -32,8 +32,11 @@
>  #include <linux/err.h>
>  #include <clock.h>
>  
> -/* time to wait for STAT_RR getting set */
> -#define IMX_SPI_RR_TIMEOUT	10000 /* ns */
> +/*
> + * time to wait for STAT_RR getting set, should allow the transfer
> + * of 24 bits at spi-max-frequency of 100kHz
> + */
> +#define IMX_SPI_RR_TIMEOUT	250000 /* ns */
>  
>  struct imx_spi {
>  	struct spi_master	master;
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox