mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Daniel Schultz <d.schultz@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCH] ARM: boards: phytec-som-am335x: Fallback ram timings
Date: Thu, 14 Dec 2017 16:51:15 +0100	[thread overview]
Message-ID: <1513266675-49103-1-git-send-email-d.schultz@phytec.de> (raw)

The 'get_ram_size' function can return false values with 1GB RAMs during
warm reset. If a not-existing RAM size will be returned, the fallback
RAM timings get loaded to prevent hangs.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
 arch/arm/boards/phytec-som-am335x/lowlevel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boards/phytec-som-am335x/lowlevel.c b/arch/arm/boards/phytec-som-am335x/lowlevel.c
index b1576ee..5030966 100644
--- a/arch/arm/boards/phytec-som-am335x/lowlevel.c
+++ b/arch/arm/boards/phytec-som-am335x/lowlevel.c
@@ -174,8 +174,9 @@ static noinline void physom_board_init(void *fdt, int sdram, int module_family)
 		/* Find the ram size and set up the correct ram timings */
 		ramsize = get_ram_size((long *) 0x80000000, SZ_1G);
 		timing = get_timings_by_size(module_family, ramsize);
+		/* In case of a failure, load generic ram timings as fallback */
 		if (!timing)
-			hang();
+			timing = get_minimal_timings(module_family);
 	}
 
 	am335x_sdram_init(DDR_IOCTRL, &physom_cmd,
-- 
2.7.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2017-12-14 15:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 15:51 Daniel Schultz [this message]
2017-12-15  7:49 ` Sascha Hauer
2017-12-22  8:09   ` Daniel Schultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513266675-49103-1-git-send-email-d.schultz@phytec.de \
    --to=d.schultz@phytec.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox