[PATCH] ARM: boards: phytec-som-am335x: Fallback ram timings

[PATCH] ARM: boards: phytec-som-am335x: Fallback ram timings

[Daniel Schultz]

The 'get_ram_size' function can return false values with 1GB RAMs during
warm reset. If a not-existing RAM size will be returned, the fallback
RAM timings get loaded to prevent hangs.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
 arch/arm/boards/phytec-som-am335x/lowlevel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boards/phytec-som-am335x/lowlevel.c b/arch/arm/boards/phytec-som-am335x/lowlevel.c
index b1576ee..5030966 100644
--- a/arch/arm/boards/phytec-som-am335x/lowlevel.c
+++ b/arch/arm/boards/phytec-som-am335x/lowlevel.c
@@ -174,8 +174,9 @@ static noinline void physom_board_init(void *fdt, int sdram, int module_family)
 		/* Find the ram size and set up the correct ram timings */
 		ramsize = get_ram_size((long *) 0x80000000, SZ_1G);
 		timing = get_timings_by_size(module_family, ramsize);
+		/* In case of a failure, load generic ram timings as fallback */
 		if (!timing)
-			hang();
+			timing = get_minimal_timings(module_family);
 	}
 
 	am335x_sdram_init(DDR_IOCTRL, &physom_cmd,
-- 
2.7.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: boards: phytec-som-am335x: Fallback ram timings

[Sascha Hauer]

Hi Daniel,

On Thu, Dec 14, 2017 at 04:51:15PM +0100, Daniel Schultz wrote:
> The 'get_ram_size' function can return false values with 1GB RAMs during
> warm reset. If a not-existing RAM size will be returned, the fallback
> RAM timings get loaded to prevent hangs.

Just continuing with wrong ram size and fallback timing is not really an
option. It doesn't help the user and only changes the bug reports you
get.

Sascha

> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
>  arch/arm/boards/phytec-som-am335x/lowlevel.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boards/phytec-som-am335x/lowlevel.c b/arch/arm/boards/phytec-som-am335x/lowlevel.c
> index b1576ee..5030966 100644
> --- a/arch/arm/boards/phytec-som-am335x/lowlevel.c
> +++ b/arch/arm/boards/phytec-som-am335x/lowlevel.c
> @@ -174,8 +174,9 @@ static noinline void physom_board_init(void *fdt, int sdram, int module_family)
>  		/* Find the ram size and set up the correct ram timings */
>  		ramsize = get_ram_size((long *) 0x80000000, SZ_1G);
>  		timing = get_timings_by_size(module_family, ramsize);
> +		/* In case of a failure, load generic ram timings as fallback */
>  		if (!timing)
> -			hang();
> +			timing = get_minimal_timings(module_family);
>  	}
>  
>  	am335x_sdram_init(DDR_IOCTRL, &physom_cmd,
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: boards: phytec-som-am335x: Fallback ram timings

[Daniel Schultz]

Hi,


On 12/15/2017 08:49 AM, Sascha Hauer wrote:
> Hi Daniel,
>
> On Thu, Dec 14, 2017 at 04:51:15PM +0100, Daniel Schultz wrote:
>> The 'get_ram_size' function can return false values with 1GB RAMs during
>> warm reset. If a not-existing RAM size will be returned, the fallback
>> RAM timings get loaded to prevent hangs.
> Just continuing with wrong ram size and fallback timing is not really an
> option. It doesn't help the user and only changes the bug reports you
> get.
>
> Sascha
>
yes, sorry. I sent a new patch to remove the bug from our MLO and I will 
investigate for this problem next year, because this seems to be a 
little more trickier.

Daniel
>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>> ---
>>   arch/arm/boards/phytec-som-am335x/lowlevel.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boards/phytec-som-am335x/lowlevel.c b/arch/arm/boards/phytec-som-am335x/lowlevel.c
>> index b1576ee..5030966 100644
>> --- a/arch/arm/boards/phytec-som-am335x/lowlevel.c
>> +++ b/arch/arm/boards/phytec-som-am335x/lowlevel.c
>> @@ -174,8 +174,9 @@ static noinline void physom_board_init(void *fdt, int sdram, int module_family)
>>   		/* Find the ram size and set up the correct ram timings */
>>   		ramsize = get_ram_size((long *) 0x80000000, SZ_1G);
>>   		timing = get_timings_by_size(module_family, ramsize);
>> +		/* In case of a failure, load generic ram timings as fallback */
>>   		if (!timing)
>> -			hang();
>> +			timing = get_minimal_timings(module_family);
>>   	}
>>   
>>   	am335x_sdram_init(DDR_IOCTRL, &physom_cmd,
>> -- 
>> 2.7.4
>>
>>
>> _______________________________________________
>> barebox mailing list
>> barebox@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/barebox
>>

-- 
Mit freundlichen Grüßen,
With best regards,
   Daniel Schultz

- Entwicklung -
Tel.: 	+49 6131 92 21 457
d.schultz@phytec.de
www.phytec.de

Sie finden uns auch auf: Facebook, LinkedIn, Xing, YouTube

PHYTEC Messtechnik GmbH | Robert-Koch-Str. 39 | 55129 Mainz, Germany
Geschäftsführer: Dipl.-Ing. Michael Mitezki, Dipl.-Ing. Bodo Huber |
Handelsregister Mainz HRB 4656 | Finanzamt Mainz-Mitte | St.Nr. 266500608,
DE 149059855
This E-Mail may contain confidential or privileged information. If you are
not the intended recipient (or have received this E-Mail in error) please
notify the sender immediately and destroy this E-Mail. Any unauthorized
copying, disclosure or distribution of the material in this E-Mail is
strictly forbidden.


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox