mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH] net/e1000: init eeprom word size if only iNVM is found
Date: Wed, 24 Jan 2018 11:34:25 +0100	[thread overview]
Message-ID: <1516790065.6411.0.camel@pengutronix.de> (raw)
In-Reply-To: <20180123144129.26630-1-l.stach@pengutronix.de>

Please drop this patch. It seems there are some more issues with the
iNVM support that I'm currently digging into.

Am Dienstag, den 23.01.2018, 15:41 +0100 schrieb Lucas Stach:
> The commit removing the iNVM enum type didn't make sure that the code
> path
> initializing the word size is also executed when only the iNVM is
> present.
> This leads to failed reads, as the read function will check the word
> size.
> 
> Fixes: 761bed13abcb (net/e1000: provide access to iNVM even if a
>                      flash is present)
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/net/e1000/eeprom.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/e1000/eeprom.c b/drivers/net/e1000/eeprom.c
> index 748d8afe7922..bf08ac87fdbb 100644
> --- a/drivers/net/e1000/eeprom.c
> +++ b/drivers/net/e1000/eeprom.c
> @@ -506,7 +506,8 @@ int32_t e1000_init_eeprom_params(struct e1000_hw
> *hw)
>  		break;
>  	}
>  
> -	if (eeprom->type == e1000_eeprom_spi) {
> +	/* SPI or iNVM */
> +	if (!eeprom->word_size) {
>  		/* eeprom_size will be an enum [0..8] that maps
>  		 * to eeprom sizes 128B to
>  		 * 32KB (incremented by powers of 2).

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2018-01-24 10:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 14:41 Lucas Stach
2018-01-24 10:34 ` Lucas Stach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516790065.6411.0.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox