mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Daniel Schultz <d.schultz@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCH 3/3] drivers: mtd: nand: omap: Return stat value
Date: Mon, 29 Jan 2018 14:04:11 +0100	[thread overview]
Message-ID: <1517231051-12129-3-git-send-email-d.schultz@phytec.de> (raw)
In-Reply-To: <1517231051-12129-1-git-send-email-d.schultz@phytec.de>

The read page function should return the total count of flipped bits,
otherwise the caller always thinks no bitflip occured.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
 drivers/mtd/nand/nand_omap_gpmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/nand_omap_gpmc.c b/drivers/mtd/nand/nand_omap_gpmc.c
index e18ce63..38f4960 100644
--- a/drivers/mtd/nand/nand_omap_gpmc.c
+++ b/drivers/mtd/nand/nand_omap_gpmc.c
@@ -712,7 +712,7 @@ static int omap_gpmc_read_page_bch_rom_mode(struct mtd_info *mtd,
 	else
 		mtd->ecc_stats.corrected += stat;
 
-	return 0;
+	return stat;
 }
 
 static int omap_gpmc_eccmode(struct gpmc_nand_info *oinfo,
-- 
2.7.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2018-01-29 13:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 13:04 [PATCH 1/3] commands: ubi: ubiupdatevol: Reduce error code to 0 or 1 Daniel Schultz
2018-01-29 13:04 ` [PATCH 2/3] ARM: configs: am335x_defconfig: Reorder configs Daniel Schultz
2018-01-29 13:04 ` Daniel Schultz [this message]
2018-01-30  7:11   ` [PATCH 3/3] drivers: mtd: nand: omap: Return stat value Sascha Hauer
2018-02-15 12:51     ` Daniel Schultz
2018-02-16  7:56       ` Sascha Hauer
2018-02-23 15:53         ` Daniel Schultz
2018-01-30  7:05 ` [PATCH 1/3] commands: ubi: ubiupdatevol: Reduce error code to 0 or 1 Sascha Hauer
2018-01-30  7:13   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517231051-12129-3-git-send-email-d.schultz@phytec.de \
    --to=d.schultz@phytec.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox