[PATCH] video: tc358767: set num_modes=0 if no valid mode found

[PATCH] video: tc358767: set num_modes=0 if no valid mode found

[Andrey Gusakov]

Since commit f986661 "video: ipu: register framebuffer,
even when no modes are found" value returned from
VPL_GET_VIDEOMODES ioctl is ignored. So set valid num_modes
in error case to avoid crash in register_framebuffer.

Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
---
 drivers/video/tc358767.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/tc358767.c b/drivers/video/tc358767.c
index 5ad5cb4..d4749b1 100644
--- a/drivers/video/tc358767.c
+++ b/drivers/video/tc358767.c
@@ -1258,6 +1258,7 @@ static int tc_filter_videomodes(struct tc_data *tc, struct display_timings *timi
 	} while (1);
 
 	free(timings->modes);
+	timings->num_modes = 0;
 	timings->modes = NULL;
 
 	if (!num_modes) {
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] video: tc358767: set num_modes=0 if no valid mode found

[Sascha Hauer]

On Fri, Mar 23, 2018 at 08:12:23PM +0300, Andrey Gusakov wrote:
> Since commit f986661 "video: ipu: register framebuffer,
> even when no modes are found" value returned from
> VPL_GET_VIDEOMODES ioctl is ignored. So set valid num_modes
> in error case to avoid crash in register_framebuffer.
> 
> Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> ---
>  drivers/video/tc358767.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/video/tc358767.c b/drivers/video/tc358767.c
> index 5ad5cb4..d4749b1 100644
> --- a/drivers/video/tc358767.c
> +++ b/drivers/video/tc358767.c
> @@ -1258,6 +1258,7 @@ static int tc_filter_videomodes(struct tc_data *tc, struct display_timings *timi
>  	} while (1);
>  
>  	free(timings->modes);
> +	timings->num_modes = 0;
>  	timings->modes = NULL;
>  
>  	if (!num_modes) {
> -- 
> 1.9.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox