* [PATCH] arm: mach-omap: bbu_emmc: Fix return value
@ 2018-08-28 7:32 Teresa Remmet
2018-08-29 6:57 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Teresa Remmet @ 2018-08-28 7:32 UTC (permalink / raw)
To: barebox
Update handler returned the written bytes of the partition table on success
instead of 0. Return 0 or error code now.
Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
---
arch/arm/mach-omap/am33xx_bbu_emmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap/am33xx_bbu_emmc.c b/arch/arm/mach-omap/am33xx_bbu_emmc.c
index d3adb3744c95..1fd7222ddcea 100644
--- a/arch/arm/mach-omap/am33xx_bbu_emmc.c
+++ b/arch/arm/mach-omap/am33xx_bbu_emmc.c
@@ -73,7 +73,7 @@ error_save_part_table:
error:
close(fd);
- return ret;
+ return (ret > 0) ? 0 : ret;
}
int am33xx_bbu_emmc_mlo_register_handler(const char *name, char *devicefile)
--
2.7.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arm: mach-omap: bbu_emmc: Fix return value
2018-08-28 7:32 [PATCH] arm: mach-omap: bbu_emmc: Fix return value Teresa Remmet
@ 2018-08-29 6:57 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-08-29 6:57 UTC (permalink / raw)
To: Teresa Remmet; +Cc: barebox
On Tue, Aug 28, 2018 at 09:32:50AM +0200, Teresa Remmet wrote:
> Update handler returned the written bytes of the partition table on success
> instead of 0. Return 0 or error code now.
>
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
> arch/arm/mach-omap/am33xx_bbu_emmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/mach-omap/am33xx_bbu_emmc.c b/arch/arm/mach-omap/am33xx_bbu_emmc.c
> index d3adb3744c95..1fd7222ddcea 100644
> --- a/arch/arm/mach-omap/am33xx_bbu_emmc.c
> +++ b/arch/arm/mach-omap/am33xx_bbu_emmc.c
> @@ -73,7 +73,7 @@ error_save_part_table:
>
> error:
> close(fd);
> - return ret;
> + return (ret > 0) ? 0 : ret;
> }
>
> int am33xx_bbu_emmc_mlo_register_handler(const char *name, char *devicefile)
> --
> 2.7.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-29 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 7:32 [PATCH] arm: mach-omap: bbu_emmc: Fix return value Teresa Remmet
2018-08-29 6:57 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox