From: Lucas Stach <l.stach@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/2] ARM: nxp-imx8mq-evk: remove SDRAM reservation for ATF
Date: Wed, 07 Nov 2018 13:02:43 +0100 [thread overview]
Message-ID: <1541592163.2508.40.camel@pengutronix.de> (raw)
In-Reply-To: <CAHQ1cqHBUguROV=pi9qq1_6D4qm07X3wzPYooqHEVcMcHNWVDA@mail.gmail.com>
Am Dienstag, den 06.11.2018, 12:57 -0800 schrieb Andrey Smirnov:
> On Tue, Nov 6, 2018 at 9:43 AM Lucas Stach <l.stach@pengutronix.de>
> wrote:
> >
> > Recent versions of the i.MX8MQ ATF (like the one shipped with
> > Barebox)
> > reside in a part of OCRAM, so there is no need to reserve any part
> > of
> > SDRAM anymore.
> >
>
> Not sure if this will be handled by Barebox, but there's also:
>
> /memreserve/ 0x40000000 0x00020000;
>
> in arch/arm/dts/imx8mq.dtsi, do we want to drop that as well?
It doesn't hurt, as Barebox isn't looking at the reserved ranges right
now, but yes it should go eventually.
Regards,
Lucas
> Other than that, definitely a good change:
>
> Acked-by: Andrey Smirnov <andrew.smirnov@gmail.com>
>
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > arch/arm/boards/nxp-imx8mq-evk/board.c | 11 -----------
> > 1 file changed, 11 deletions(-)
> >
> > diff --git a/arch/arm/boards/nxp-imx8mq-evk/board.c
> > b/arch/arm/boards/nxp-imx8mq-evk/board.c
> > index 764eadb766a9..7918b5fb3e36 100644
> > --- a/arch/arm/boards/nxp-imx8mq-evk/board.c
> > +++ b/arch/arm/boards/nxp-imx8mq-evk/board.c
> > @@ -45,17 +45,6 @@ static int ar8031_phy_fixup(struct phy_device
> > *phydev)
> > return 0;
> > }
> >
> > -static int imx8mq_evk_mem_init(void)
> > -{
> > - if (!of_machine_is_compatible("fsl,imx8mq-evk"))
> > - return 0;
> > -
> > - request_sdram_region("ATF", 0x40000000, SZ_128K);
> > -
> > - return 0;
> > -}
> > -mem_initcall(imx8mq_evk_mem_init);
> > -
> > static int nxp_imx8mq_evk_init(void)
> > {
> > if (!of_machine_is_compatible("fsl,imx8mq-evk"))
> > --
> > 2.19.1
> >
> >
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2018-11-07 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 17:42 Lucas Stach
2018-11-06 17:42 ` [PATCH 2/2] ARM: nxp-imx8mq-evk: add barebox and env partitions Lucas Stach
2018-11-06 21:14 ` Andrey Smirnov
2018-11-06 20:57 ` [PATCH 1/2] ARM: nxp-imx8mq-evk: remove SDRAM reservation for ATF Andrey Smirnov
2018-11-07 12:02 ` Lucas Stach [this message]
2018-11-09 7:24 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541592163.2508.40.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox