mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>,
	barebox@lists.infradead.org
Subject: Re: [PATCH 1/6] mach-bcm2835/core: add clkdev for uart1
Date: Wed, 12 Dec 2018 15:22:04 +0100	[thread overview]
Message-ID: <1544624524.3137.23.camel@pengutronix.de> (raw)
In-Reply-To: <20181212141054.7513-2-r.czerwinski@pengutronix.de>

Am Mittwoch, den 12.12.2018, 15:10 +0100 schrieb Rouven Czerwinski:
> Add a clkdev for uart1 which will be used on the Raspberry Pi 3.
> Double the clockrate since the ns16550 driver used for the uart will divide by
> 16, while the bcm2835 peripheral manual describes that the bcm2835 miniuart will
> only divide by 8.
> 
> > Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>  arch/arm/mach-bcm283x/core.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/mach-bcm283x/core.c b/arch/arm/mach-bcm283x/core.c
> index f1dcda86f..66af76b09 100644
> --- a/arch/arm/mach-bcm283x/core.c
> +++ b/arch/arm/mach-bcm283x/core.c
> @@ -42,6 +42,12 @@ static int bcm2835_clk_init(void)
> >  	clk_register_clkdev(clk, NULL, "uart0-pl0110");
> >  	clkdev_add_physbase(clk, 0x20201000, NULL);
> >  	clkdev_add_physbase(clk, 0x3f201000, NULL);
> > +	/*
> > +	 * We double the clock rate since the 16550 will divide by 16
> > +	 * (instead of 8 required by the BCM2835 peripheral manual)
> +	 */

This is confusing. The clock is running at another rate. I would prefer
to do this adjustment in rpi_init_port() in the ns16550 driver, as
that's the point where the hardware deviation actually is.

Regards,
Lucas

> +	clk = clk_fixed("uart1-8250", 500 * 1000 * 1000);
> > +	clkdev_add_physbase(clk, 0x3f215040, NULL);
>  
> >  	clk = clk_fixed("bcm2835-cs", 1 * 1000 * 1000);
> >  	clk_register_clkdev(clk, NULL, "bcm2835-cs");

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-12-12 14:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 14:10 [PATCH 0/6] Raspberry Pi miniuart support Rouven Czerwinski
2018-12-12 14:10 ` [PATCH 1/6] mach-bcm2835/core: add clkdev for uart1 Rouven Czerwinski
2018-12-12 14:22   ` Lucas Stach [this message]
2018-12-12 14:58     ` Rouven Czerwinski
2018-12-12 14:10 ` [PATCH 2/6] serial_ns16550: handle default reg-io-width Rouven Czerwinski
2018-12-12 14:10 ` [PATCH 3/6] serial_ns16550: add raspberry pi compatible and init Rouven Czerwinski
2018-12-13  7:14   ` Sascha Hauer
2018-12-12 14:10 ` [PATCH 4/6] ARM: rpi: add NS16550 support Rouven Czerwinski
2018-12-12 14:10 ` [PATCH 5/6] bcm2837-rpi-3: choose miniuart as stdout Rouven Czerwinski
2018-12-12 14:10 ` [PATCH 6/6] doc: bcm283x: remove miniuart overlay instruction Rouven Czerwinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1544624524.3137.23.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=r.czerwinski@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox