* [PATCH for next] mtd: nand: nand_base: Fix compile warning if CONFIG_MTD_WRITE is not enabled
@ 2018-12-17 15:43 Teresa Remmet
2018-12-18 7:15 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Teresa Remmet @ 2018-12-17 15:43 UTC (permalink / raw)
To: barebox
drivers/mtd/nand/nand_base.c:337:12: warning: 'nand_default_block_markbad'
defined but not used [-Wunused-function]
Add __maybe_unused again to silence warning when CONFIG_MTD_WRITE is not enabled.
Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
---
drivers/mtd/nand/nand_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 05bfac15f822..8ae6f344686d 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -334,7 +334,7 @@ static int nand_block_bad(struct mtd_info *mtd, loff_t ofs, int getchip)
* specific driver. It provides the details for writing a bad block marker to a
* block.
*/
-static int nand_default_block_markbad(struct mtd_info *mtd, loff_t ofs)
+static __maybe_unused int nand_default_block_markbad(struct mtd_info *mtd, loff_t ofs)
{
struct nand_chip *chip = mtd->priv;
struct mtd_oob_ops ops;
--
2.7.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH for next] mtd: nand: nand_base: Fix compile warning if CONFIG_MTD_WRITE is not enabled
2018-12-17 15:43 [PATCH for next] mtd: nand: nand_base: Fix compile warning if CONFIG_MTD_WRITE is not enabled Teresa Remmet
@ 2018-12-18 7:15 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2018-12-18 7:15 UTC (permalink / raw)
To: Teresa Remmet; +Cc: barebox
On Mon, Dec 17, 2018 at 04:43:43PM +0100, Teresa Remmet wrote:
> drivers/mtd/nand/nand_base.c:337:12: warning: 'nand_default_block_markbad'
> defined but not used [-Wunused-function]
>
> Add __maybe_unused again to silence warning when CONFIG_MTD_WRITE is not enabled.
>
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
> drivers/mtd/nand/nand_base.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index 05bfac15f822..8ae6f344686d 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -334,7 +334,7 @@ static int nand_block_bad(struct mtd_info *mtd, loff_t ofs, int getchip)
> * specific driver. It provides the details for writing a bad block marker to a
> * block.
> */
> -static int nand_default_block_markbad(struct mtd_info *mtd, loff_t ofs)
> +static __maybe_unused int nand_default_block_markbad(struct mtd_info *mtd, loff_t ofs)
> {
> struct nand_chip *chip = mtd->priv;
> struct mtd_oob_ops ops;
> --
> 2.7.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-18 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-17 15:43 [PATCH for next] mtd: nand: nand_base: Fix compile warning if CONFIG_MTD_WRITE is not enabled Teresa Remmet
2018-12-18 7:15 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox