Re: [PATCH v4 2/7] ARM: rpi: retrieve miniuart clock from firmware

[Rouven Czerwinski <r.czerwinski@pengutronix.de>]

On Tue, 2018-12-18 at 08:21 +0100, Sascha Hauer wrote:
> On Mon, Dec 17, 2018 at 09:10:40AM +0100, Rouven Czerwinski wrote:
> > The miniuart uses the core clock as the clock source. This clock is
> > fixed by the
> > firmware to 250Mhz if enable_uart=1 is set in the config.txt file.
> > However a user could still choose to overclock the core frequency,
> > which would result in wrong baudrates computed by barebox.
> > Retrieve the core clock frequency from the firmware to allow all
> > potential
> > firmware configurations to work with barebox.
> > 
> > Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> > ---
> >  arch/arm/boards/raspberry-pi/rpi-common.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm/boards/raspberry-pi/rpi-common.c
> > b/arch/arm/boards/raspberry-pi/rpi-common.c
> > index 490aeef..e29177d 100644
> > --- a/arch/arm/boards/raspberry-pi/rpi-common.c
> > +++ b/arch/arm/boards/raspberry-pi/rpi-common.c
> > @@ -309,6 +309,13 @@ static int rpi_console_clock_init(void)
> >  	clkdev_add_physbase(clk, 0x20201000, NULL);
> >  	clkdev_add_physbase(clk, 0x3f201000, NULL);
> >  
> > +	clk =
> > rpi_register_firmware_clock(BCM2835_MBOX_CLOCK_ID_CORE,
> > +					  "uart1-8250");
> 
> We don't have this function anywhere in the tree, this breaks
> compilation.
Yes the base on my series was wrong, its missing a cleanup patch.

Do you want a single patch or shall I post a new series which
incorporates the suggestions from Roland and you?

- Rouven

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox