Re: [PATCH v6 0/9] Raspberry Pi miniuart support

From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v6 0/9] Raspberry Pi miniuart support
Date: Tue, 15 Jan 2019 13:51:32 +0100	[thread overview]
Message-ID: <1547556692.4278.1.camel@pengutronix.de> (raw)
In-Reply-To: <20190115110111.mkedj7f2gmvsp4va@pengutronix.de>

Looks like RPI W is wired the same way as RPI3.
I think for the RPI Zero W you'll need two additional lines:

#define BCM2835_MINIUART_BASE 0x20215040

and
clkdev_add_physbase(clk, BCM2835_MINIUART_BASE, NULL);
in rpi_console_clock_init.

These should enable the clkdev for the uart and should barebox allow to
probe the miniuart on RPI Zero W.

Don't forget to remove the uart_2ndstage=1, this line also switches
PL011 and the miniuart.

- Emantor

On Tue, 2019-01-15 at 12:01 +0100, Roland Hieber wrote:
> Hi,
> 
> just a short notice, I tested in on my small board farm, RPi 1 and
> RPi 3
> boot okay, but RPi Zero W doesn't show a barebox prompt. When
> enabling
> uart_2ndstage=1 in config.txt, the firmware hangs after
> 
>     MESS:00:00:02.864061:0: uart: Baud rate change done...
>     MESS:00:00:02.867490:0: uart: Baud rate
> 
> The docs don't claim that we officially to support that board
> though... :P
> 
>  - Roland
> 
> On Tue, Jan 15, 2019 at 06:44:00AM +0100, Rouven Czerwinski wrote:
> > This patch series adds support for the raspberry pi miniuart (also
> > called
> > aux-uart) to barebox.
> > With this series the miniuart overlay is no longer necessary to
> > start barebox on
> > Raspberry Pi 3.
> > 
> > v6:
> > - Remove leftover val and missing fixup of the AUX Clock defines
> > 
> > v5:
> > - Add defines for register and base values
> >   from Sascha Hauer and Roland Hieber
> > 
> > v4:
> > - Fix indentation for compatible
> > - Fix __maybe_unused annnotation for rpi_drvdata missed in v3
> >   from Sascha Hauer
> > 
> > v3:
> > - Fix Indentation
> >   from Oleksij Rempel and Sascha Hauer
> > 
> > v2:
> > - Move console clock initialization into board core
> > - Retrieve the core clock frequency for the miniuart from the
> > firmware
> > - Double the clock frequency in the ns16550 rpi init function
> > instead of
> >   during initialization
> >   from Lucas Stach
> > 
> > Rouven Czerwinski (9):
> >   ARM: rpi: fix typo in rpi-common.c
> >   ARM: rpi: move clks into board specific rpi-common
> >   ARM: rpi: retrieve miniuart clock from firmware
> >   serial_ns16550: handle default reg-io-width
> >   serial_ns16550: add raspberry pi compatible and init
> >   ARM: rpi: add NS16550 support
> >   ARM: rpi: choose miniuart as stdout
> >   doc: bcm283x: remove miniuart overlay instruction
> >   ARM: rpi: use defines for uart bases
> > 
> >  Documentation/boards/bcm2835.rst          |  1 +-
> >  arch/arm/boards/raspberry-pi/rpi-common.c | 34 ++++++++++-
> >  arch/arm/configs/rpi_defconfig            |  1 +-
> >  arch/arm/dts/bcm2837-rpi-3.dts            |  7 +--
> >  arch/arm/mach-bcm283x/core.c              | 19 +------
> >  drivers/serial/serial_ns16550.c           | 74 ++++++++++++++++---
> > -----
> >  6 files changed, 85 insertions(+), 51 deletions(-)
> > 
> > base-commit: 0b5361a328632e64c14a54306119093a0c7fecdf
> > -- 
> > git-series 0.9.1
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> > 
> 
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox