From: Lucas Stach <l.stach@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH 7/7] ARM: imx8mq-zii-ultra: Add USB related nodes
Date: Wed, 27 Feb 2019 12:10:23 +0100 [thread overview]
Message-ID: <1551265823.2305.10.camel@pengutronix.de> (raw)
In-Reply-To: <20190227031657.19896-8-andrew.smirnov@gmail.com>
Am Dienstag, den 26.02.2019, 19:16 -0800 schrieb Andrey Smirnov:
> Add nodes for exposed USB ports as well as USB hub connected to one of
> them.
>
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> arch/arm/dts/imx8mq-zii-ultra-rmb3.dts | 4 +++
> arch/arm/dts/imx8mq-zii-ultra.dtsi | 34 ++++++++++++++++++++++++++
> 2 files changed, 38 insertions(+)
>
> diff --git a/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts b/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts
> index b2b3a560b..78280029b 100644
> --- a/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts
> +++ b/arch/arm/dts/imx8mq-zii-ultra-rmb3.dts
> @@ -37,3 +37,7 @@
> > >;
> > };
> };
> +
> +&usb_hub {
> + port-swap=<0x01>;
This is wrong. With the upstream driver/binding this should be:
swap-dx-lanes = <0>;
> +};
> diff --git a/arch/arm/dts/imx8mq-zii-ultra.dtsi b/arch/arm/dts/imx8mq-zii-ultra.dtsi
> index 83d57916e..d46a26d81 100644
> --- a/arch/arm/dts/imx8mq-zii-ultra.dtsi
> +++ b/arch/arm/dts/imx8mq-zii-ultra.dtsi
> @@ -226,6 +226,16 @@
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_i2c3>;
> > status = "okay";
> +
> > > + usb_hub: usb2513b@2c {
> > + compatible = "microchip,usb2513b";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_usb2513b>;
> > + #address-cells=<1>;
> + #size-cells=<1>;
Why the address-cells and size-cells here? I don't see why this is
needed.
Regards,
Lucas
> + reg = <0x2c>;
> > + reset-gpios = <&gpio3 25 GPIO_ACTIVE_LOW>;
> > + };
> };
>
> &i2c4 {
> @@ -312,6 +322,24 @@
> > };
> };
>
> +&usb_dwc3_0 {
> > + status = "okay";
> > + dr_mode = "host";
> +};
> +
> +&usb3_phy0 {
> > + status = "okay";
> +};
> +
> +&usb_dwc3_1 {
> > + status = "okay";
> > + dr_mode = "host";
> +};
> +
> +&usb3_phy1 {
> > + status = "okay";
> +};
> +
> &usdhc1 {
> > pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > pinctrl-0 = <&pinctrl_usdhc1>;
> @@ -426,6 +454,12 @@
> > >;
> > };
>
> > + pinctrl_usb2513b: usb2513bgrp {
> > + fsl,pins = <
> > + MX8MQ_IOMUXC_SAI5_MCLK_GPIO3_IO25 0x41
> > + >;
> > + };
> +
> > pinctrl_usdhc1: usdhc1grp {
> > fsl,pins = <
> > > MX8MQ_IOMUXC_SD1_CLK_USDHC1_CLK 0x83
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-27 11:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 3:16 [PATCH 0/7] i.MX8MQ PCIe/USB DT changes Andrey Smirnov
2019-02-27 3:16 ` [PATCH 1/7] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ Andrey Smirnov
2019-02-27 3:16 ` [PATCH 2/7] ARM: imx8mq: Add node for SRC IP block Andrey Smirnov
2019-02-27 3:16 ` [PATCH 3/7] ARM: imx8mq: Add node for GPC " Andrey Smirnov
2019-02-27 3:16 ` [PATCH 4/7] ARM: imx8mq: Add nodes for PCIE1 and PCIE2 IP blocks Andrey Smirnov
2019-02-27 3:16 ` [PATCH 5/7] ARM: imx8mq-zii-ultra: Enable PCIE1 and PCIE2 Andrey Smirnov
2019-02-27 11:18 ` Lucas Stach
2019-02-28 2:42 ` Andrey Smirnov
2019-02-27 3:16 ` [PATCH 6/7] ARM: dts: imx8mq: Add nodes for USB IP blocks Andrey Smirnov
2019-02-27 3:16 ` [PATCH 7/7] ARM: imx8mq-zii-ultra: Add USB related nodes Andrey Smirnov
2019-02-27 11:10 ` Lucas Stach [this message]
2019-02-28 2:43 ` Andrey Smirnov
2019-02-27 7:43 ` [PATCH 0/7] i.MX8MQ PCIe/USB DT changes Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551265823.2305.10.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox