mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Robert Karszniewicz <r.karszniewicz@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2] libfile: copy_file: prevent spurious error message
Date: Wed, 16 Oct 2019 13:26:06 +0200	[thread overview]
Message-ID: <1571225166-309934-1-git-send-email-r.karszniewicz@phytec.de> (raw)
In-Reply-To: <1571155150-124984-1-git-send-email-r.karszniewicz@phytec.de>

Before this, if the function bails out somewhere at a later point, this
return value will be outdated and will produce a misleading error
message down the line.

Signed-off-by: Robert Karszniewicz <r.karszniewicz@phytec.de>
---
Changes from v1:
- commit message

 lib/libfile.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/libfile.c b/lib/libfile.c
index 3f3ec21..319e66b 100644
--- a/lib/libfile.c
+++ b/lib/libfile.c
@@ -349,6 +349,7 @@ int copy_file(const char *src, const char *dst, int verbose)
 	ret = stat(dst, &dststat);
 	if (ret && ret != -ENOENT)
 		goto out;
+	ret = 0;
 
 	/* Set O_TRUNC only if file exist and is a regular file */
 	if (!ret && S_ISREG(dststat.st_mode))
-- 
2.7.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-10-16 11:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 15:59 [PATCH] " Robert Karszniewicz
2019-10-16 11:26 ` Robert Karszniewicz [this message]
2019-10-18 11:45   ` [PATCH v2] " Sascha Hauer
2019-10-18 17:10     ` [PATCH v3] " Robert Karszniewicz
2019-10-18 17:15       ` Robert Karszniewicz
2019-10-21  7:37         ` Sascha Hauer
2019-10-22 13:47           ` [PATCH v4] libfile: copy_file: fix error handling Robert Karszniewicz
2019-10-23  7:16             ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1571225166-309934-1-git-send-email-r.karszniewicz@phytec.de \
    --to=r.karszniewicz@phytec.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox