From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Enrico Jorns <ejo@pengutronix.de>, barebox@lists.infradead.org
Cc: afa@pengutronix.de
Subject: Re: [PATCH] usb: dwc2: more precise and helpful message for dr_mode config issues
Date: Mon, 17 May 2021 14:51:20 +0200 [thread overview]
Message-ID: <168256df-6673-dd27-0cb4-9b7949e8098f@pengutronix.de> (raw)
In-Reply-To: <20210517124941.31301-1-ejo@pengutronix.de>
On 17.05.21 14:49, Enrico Jorns wrote:
> With the previous message I misunderstood that the 'configuration
> mismatch' was caused by any entity forcing the dr_mode to
> 'host'/'device'.
> The actual intention however is to tell the user that the selected
> 'dr_mode' does not match the capabilities provided by the controller or
> the selected driver parts (USB_DWC2_HOST/USB_DWC2_GADGET).
>
> The updated warning message attempts to reflect this more explicitly.
>
> Also rename 'device' to 'peripheral' as it is named both in dtb and
> in macros that way.
>
> Signed-off-by: Enrico Jorns <ejo@pengutronix.de>
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/usb/dwc2/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
> index cc5729ed92..6dfe14f174 100644
> --- a/drivers/usb/dwc2/core.c
> +++ b/drivers/usb/dwc2/core.c
> @@ -672,8 +672,8 @@ int dwc2_get_dr_mode(struct dwc2 *dwc2)
>
> if (mode != dwc2->dr_mode) {
> dwc2_warn(dwc2,
> - "Configuration mismatch. dr_mode forced to %s\n",
> - mode == USB_DR_MODE_HOST ? "host" : "device");
> + "Selected dr_mode not supported by controller/driver. Enforcing '%s' mode.\n",
> + mode == USB_DR_MODE_HOST ? "host" : "peripheral");
>
> dwc2->dr_mode = mode;
> }
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2021-05-17 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 12:49 Enrico Jorns
2021-05-17 12:51 ` Ahmad Fatoum [this message]
2021-05-18 6:34 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168256df-6673-dd27-0cb4-9b7949e8098f@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=afa@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ejo@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox