mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fixup! ARM: i.MX8M: return error if imx_load_image can't honour entry address
@ 2024-01-16  9:49 Ahmad Fatoum
  2024-01-17  7:16 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2024-01-16  9:49 UTC (permalink / raw)
  To: barebox; +Cc: Marco Felsch, Ahmad Fatoum

Align the now outdated comment with reality.

Suggested-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/mach-imx/xload-common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-imx/xload-common.c b/arch/arm/mach-imx/xload-common.c
index 32f12cd7f574..e7f8f162ee8f 100644
--- a/arch/arm/mach-imx/xload-common.c
+++ b/arch/arm/mach-imx/xload-common.c
@@ -123,8 +123,8 @@ int imx_load_image(ptrdiff_t address, ptrdiff_t entry, u32 offset,
 
 	if (!start) {
 		/*
-		 * Passing entry different from address is interpreted
-		 * as a request to place the image such that its entry
+		 * When !start, the caller will start the image later on,
+		 * expecting that it is placed such that its entry
 		 * point would be exactly at 'entry', that is:
 		 *
 		 *     buf + ofs = entry
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fixup! ARM: i.MX8M: return error if imx_load_image can't honour entry address
  2024-01-16  9:49 [PATCH] fixup! ARM: i.MX8M: return error if imx_load_image can't honour entry address Ahmad Fatoum
@ 2024-01-17  7:16 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-01-17  7:16 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum; +Cc: Marco Felsch


On Tue, 16 Jan 2024 10:49:21 +0100, Ahmad Fatoum wrote:
> Align the now outdated comment with reality.
> 
> 

Applied, thanks!

[1/1] fixup! ARM: i.MX8M: return error if imx_load_image can't honour entry address
      (no commit info)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-17  7:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-16  9:49 [PATCH] fixup! ARM: i.MX8M: return error if imx_load_image can't honour entry address Ahmad Fatoum
2024-01-17  7:16 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox