From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH] watchdog: restart handler: hang when watchdog cannot restart the machine
Date: Thu, 08 Feb 2024 08:10:44 +0100 [thread overview]
Message-ID: <170737624473.350501.15338275363006292758.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240205115226.2432028-1-s.hauer@pengutronix.de>
On Mon, 05 Feb 2024 12:52:26 +0100, Sascha Hauer wrote:
> The __builtin_unreachable() in watchdog_restart_handle() is bogus,
> because when the watchdog doesn't work we will run into
> __builtin_unreachable() and behaviour is undefined. Drop the call
> to __builtin_unreachable(), print a big fat warning and hang() the
> machine which makes sure we don't return from watchdog_restart_handle().
>
>
> [...]
Applied, thanks!
[1/1] watchdog: restart handler: hang when watchdog cannot restart the machine
https://git.pengutronix.de/cgit/barebox/commit/?id=ddf0d5cf35aa (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-02-08 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 11:52 Sascha Hauer
2024-02-08 7:10 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170737624473.350501.15338275363006292758.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox