From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 19 Feb 2024 09:02:08 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rbybI-00E1IO-1l for lore@lore.pengutronix.de; Mon, 19 Feb 2024 09:02:08 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rbybG-0001Jm-0l for lore@pengutronix.de; Mon, 19 Feb 2024 09:02:08 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-Id:Subject:References:In-Reply-To:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TEe0K45SDXg9Z7fKUTvCcfTUejX9Oi+/Xb4OmTkpUwE=; b=UDiFwTi5kw1r77OCByXrcLZKhh wbDg5TW6Xzw9v7BmESvwJCWOy+tTYIrv/Ezdw+esZNMRcOsf1vjMfzMGkAPj+yMMtMaPQfott6fb4 A/driPyG46FJwn8BhhGyQ/yzc+xw18skyPdl/GRfmZPOdJz6lkheyRJx8nzmDR7+Fc+tSo5ydpMTu lUmCzx1L0uY5mGmLpsHzJ1Y2oJnFXl5MfFpnast2Dl4HrxVyeDYmAf8E1heGH+c+p/+RP/pg0Bx4E 70EPo3DaAZVmsNVu7dCAfUFRdPc6EtIo+Z7+CvR2Yk4HTB2vbGMyxPVX388wSqEoCWGv6z9m4Q++4 GVSkU3Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbyaO-00000009UV2-2NK4; Mon, 19 Feb 2024 08:01:12 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rbyaL-00000009URx-33g1 for barebox@lists.infradead.org; Mon, 19 Feb 2024 08:01:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rbyaH-0001AM-MB; Mon, 19 Feb 2024 09:01:05 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rbyaH-001bJv-9m; Mon, 19 Feb 2024 09:01:05 +0100 Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96) (envelope-from ) id 1rbyaH-009rNt-0m; Mon, 19 Feb 2024 09:01:05 +0100 From: Sascha Hauer To: barebox@lists.infradead.org, Ahmad Fatoum In-Reply-To: <20240216220337.2327115-1-a.fatoum@pengutronix.de> References: <20240216220337.2327115-1-a.fatoum@pengutronix.de> Message-Id: <170832966523.2350146.17482955738647323283.b4-ty@pengutronix.de> Date: Mon, 19 Feb 2024 09:01:05 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_000109_800139_82E2F6E0 X-CRM114-Status: UNSURE ( 6.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH master] i2c: don't return error pointers from of_find_i2c_adapter_by_node X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Fri, 16 Feb 2024 23:03:37 +0100, Ahmad Fatoum wrote: > All callers of of_find_i2c_adapter_by_node expect errors to be indicated > by NULL and don't check non-NULL pointers with IS_ERR(). > > Therefore map of_device_ensure_probed() errors to NULL as well to avoid > dereferencing error pointers. > > > [...] Applied, thanks! [1/1] i2c: don't return error pointers from of_find_i2c_adapter_by_node https://git.pengutronix.de/cgit/barebox/commit/?id=70b782b6b222 (link may not be stable) Best regards, -- Sascha Hauer