From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Oleksij Rempel <o.rempel@pengutronix.de>
Cc: David Jander <david@protonic.nl>
Subject: Re: [PATCH v1] spi: stm32: avoid enabling SPI in setup to allow register configuration
Date: Thu, 30 May 2024 15:24:02 +0200 [thread overview]
Message-ID: <171707544219.2070692.5571978277298286575.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240529100838.551840-1-o.rempel@pengutronix.de>
On Wed, 29 May 2024 12:08:38 +0200, Oleksij Rempel wrote:
> The stm32_spi_setup function configures the STM32 SPI engine by setting
> the SPI mode and speed. However, enabling the SPI peripheral during this
> process blocks all changes to configuration registers, causing the
> configuration writes to be ignored.
>
> Remove stm32_spi_enable calls from stm32_spi_setup to ensure proper
> configuration of the SPI registers before enabling the peripheral.
>
> [...]
Applied, thanks!
[1/1] spi: stm32: avoid enabling SPI in setup to allow register configuration
https://git.pengutronix.de/cgit/barebox/commit/?id=e548c6f567f2 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-05-30 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 10:08 Oleksij Rempel
2024-05-30 13:24 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171707544219.2070692.5571978277298286575.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=david@protonic.nl \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox