* [PATCH] fs: pstore: ram_core: use pr_err, not pr_info, for errors
@ 2024-07-01 7:05 Ahmad Fatoum
2024-07-01 10:10 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2024-07-01 7:05 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
A failure in persistent_ram_init_ecc() ultimately results in
ramoops_probe() failing, so an error message is more appropriate than
the current info log level.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
fs/pstore/ram_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index fbc936a44fd6..496c803045c3 100644
--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -207,7 +207,7 @@ static int persistent_ram_init_ecc(struct persistent_ram_zone *prz,
prz->rs_decoder = init_rs(prz->ecc_info.symsize, prz->ecc_info.poly,
0, 1, prz->ecc_info.ecc_size);
if (prz->rs_decoder == NULL) {
- pr_info("init_rs failed\n");
+ pr_err("init_rs failed\n");
return -EINVAL;
}
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: pstore: ram_core: use pr_err, not pr_info, for errors
2024-07-01 7:05 [PATCH] fs: pstore: ram_core: use pr_err, not pr_info, for errors Ahmad Fatoum
@ 2024-07-01 10:10 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-07-01 10:10 UTC (permalink / raw)
To: barebox, Ahmad Fatoum
On Mon, 01 Jul 2024 09:05:47 +0200, Ahmad Fatoum wrote:
> A failure in persistent_ram_init_ecc() ultimately results in
> ramoops_probe() failing, so an error message is more appropriate than
> the current info log level.
>
>
Applied, thanks!
[1/1] fs: pstore: ram_core: use pr_err, not pr_info, for errors
https://git.pengutronix.de/cgit/barebox/commit/?id=55cfd01e4b40 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-01 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-01 7:05 [PATCH] fs: pstore: ram_core: use pr_err, not pr_info, for errors Ahmad Fatoum
2024-07-01 10:10 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox