mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>,
	 Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH] mtd: rawnand: Ensure ECC configuration is propagated to upper layers
Date: Wed, 03 Jul 2024 10:53:55 +0200	[thread overview]
Message-ID: <171999683580.666015.1486863592198613491.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240702084455.697720-1-s.hauer@pengutronix.de>


On Tue, 02 Jul 2024 10:44:55 +0200, Sascha Hauer wrote:
> This is an adoption of Linux Commit:
> 
> |commit 3a1b777eb9fb75d09c45ae5dd1d007eddcbebf1f
> |Author: Miquel Raynal <miquel.raynal@bootlin.com>
> |Date:   Tue May 7 10:58:42 2024 +0200
> |
> |    mtd: rawnand: Ensure ECC configuration is propagated to upper layers
> |
> |    Until recently the "upper layer" was MTD. But following incremental
> |    reworks to bring spi-nand support and more recently generic ECC support,
> |    there is now an intermediate "generic NAND" layer that also needs to get
> |    access to some values. When using "converted" ECC engines, like the
> |    software ones, these values are already propagated correctly. But
> |    otherwise when using good old raw NAND controller drivers, we need to
> |    manually set these values ourselves at the end of the "scan" operation,
> |    once these values have been negotiated.
> |
> |    Without this propagation, later (generic) checks like the one warning
> |    users that the ECC strength is not high enough might simply no longer
> |    work.
> |
> |    Fixes: 8c126720fe10 ("mtd: rawnand: Use the ECC framework nand_ecc_is_strong_enough() helper")
> |    Cc: stable@vger.kernel.org
> |    Reported-by: Sascha Hauer <s.hauer@pengutronix.de>
> |    Closes: https://lore.kernel.org/all/Zhe2JtvvN1M4Ompw@pengutronix.de/
> |    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> |    Tested-by: Sascha Hauer <s.hauer@pengutronix.de>
> |    Link: https://lore.kernel.org/linux-mtd/20240507085842.108844-1-miquel.raynal@bootlin.com
> 
> [...]

Applied, thanks!

[1/1] mtd: rawnand: Ensure ECC configuration is propagated to upper layers
      https://git.pengutronix.de/cgit/barebox/commit/?id=0f5c97472bfb (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




      reply	other threads:[~2024-07-03  8:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02  8:44 Sascha Hauer
2024-07-03  8:53 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171999683580.666015.1486863592198613491.b4-ty@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox