[PATCH] common: make BOOTM_SHOW_TYPE depend on UIMAGE

[PATCH] common: make BOOTM_SHOW_TYPE depend on UIMAGE

[Ahmad Fatoum]

The config option only controls whether some extra uImage tags are
displayed extracted by calling functions in image.c.

Rename image.c to uimage_types.c to make clear that it is
uImage-specific and hide the option when UIMAGE is not enabled.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/Kconfig                     | 4 ++--
 common/Makefile                    | 2 +-
 common/{image.c => uimage_types.c} | 0
 3 files changed, 3 insertions(+), 3 deletions(-)
 rename common/{image.c => uimage_types.c} (100%)

diff --git a/common/Kconfig b/common/Kconfig
index 4500feb66c92..e505032e14d1 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -573,8 +573,8 @@ menuconfig BOOTM
 
 config BOOTM_SHOW_TYPE
 	bool
-	depends on BOOTM
-	prompt "show image information"
+	depends on BOOTM && UIMAGE
+	prompt "show uImage information"
 	help
 	  Displays some tags from the uImage:
 
diff --git a/common/Makefile b/common/Makefile
index e88f60b6d762..e66dc04bd874 100644
--- a/common/Makefile
+++ b/common/Makefile
@@ -69,7 +69,7 @@ obj-$(CONFIG_SHELL_SIMPLE)	+= parser.o
 obj-$(CONFIG_STATE)		+= state/
 obj-$(CONFIG_RATP)		+= ratp/
 obj-$(CONFIG_BOOTCHOOSER)	+= bootchooser.o
-obj-$(CONFIG_UIMAGE)		+= image.o uimage.o
+obj-$(CONFIG_UIMAGE)		+= uimage_types.o uimage.o
 obj-$(CONFIG_FITIMAGE)		+= image-fit.o
 obj-$(CONFIG_MENUTREE)		+= menutree.o
 lwl-$(CONFIG_IMD)		+= imd-barebox.o
diff --git a/common/image.c b/common/uimage_types.c
similarity index 100%
rename from common/image.c
rename to common/uimage_types.c
-- 
2.39.2

Re: [PATCH] common: make BOOTM_SHOW_TYPE depend on UIMAGE

[Sascha Hauer]

On Fri, 09 Aug 2024 16:18:08 +0200, Ahmad Fatoum wrote:
> The config option only controls whether some extra uImage tags are
> displayed extracted by calling functions in image.c.
> 
> Rename image.c to uimage_types.c to make clear that it is
> uImage-specific and hide the option when UIMAGE is not enabled.
> 
> 
> [...]

Applied, thanks!

[1/1] common: make BOOTM_SHOW_TYPE depend on UIMAGE
      https://git.pengutronix.de/cgit/barebox/commit/?id=d33b8775bc97 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>