From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 1/3] fastboot: print all variables only on getvar:all and not its prefixes
Date: Wed, 14 Aug 2024 10:53:01 +0200 [thread overview]
Message-ID: <172362558191.1292477.4999119873328319220.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240809141959.313914-1-a.fatoum@pengutronix.de>
On Fri, 09 Aug 2024 16:19:57 +0200, Ahmad Fatoum wrote:
> strcmp_l1 compares up to the length of the first arguments, i.e. it does
> a prefix check. For this, the prefix, which is usually a string literal,
> needs to be the first argument.
>
> The check for getvar:all doesn't follow this with the result that all of
>
> fastboot getvar 'all'
> fastboot getvar 'al'
> fastboot getvar 'a'
> fastboot getvar ''
>
> [...]
Applied, thanks!
[1/3] fastboot: print all variables only on getvar:all and not its prefixes
https://git.pengutronix.de/cgit/barebox/commit/?id=aff71a944811 (link may not be stable)
[2/3] fastboot: retire strcmp_l1 in favor of str_has_prefix
https://git.pengutronix.de/cgit/barebox/commit/?id=bec2074b771d (link may not be stable)
[3/3] fastboot: avoid console_countdown_abort for getvar request
https://git.pengutronix.de/cgit/barebox/commit/?id=23f330f1c8f3 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-08-14 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 14:19 Ahmad Fatoum
2024-08-09 14:19 ` [PATCH 2/3] fastboot: retire strcmp_l1 in favor of str_has_prefix Ahmad Fatoum
2024-08-09 14:19 ` [PATCH 3/3] fastboot: avoid console_countdown_abort for getvar request Ahmad Fatoum
2024-08-14 8:53 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172362558191.1292477.4999119873328319220.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox