From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 1/2] include: linux/math.h: promote DIV_ROUND_UP_ULL args to 64-bit
Date: Tue, 20 Aug 2024 14:07:54 +0200 [thread overview]
Message-ID: <172415567436.4005446.11474985151638230302.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240815065646.1156788-1-a.fatoum@pengutronix.de>
On Thu, 15 Aug 2024 08:56:45 +0200, Ahmad Fatoum wrote:
> DIV_ROUND_DOWN_ULL promotes division arguments to 64-bit, but
> DIV_ROUND_UP_ULL did so only for the division, not the addition for the
> round up. This would lead to a wrong result when the 32-bit addition
> wraps around.
>
> Linux has an explicit cast to fix this, so do likewise in barebox.
>
> [...]
Applied, thanks!
[1/2] include: linux/math.h: promote DIV_ROUND_UP_ULL args to 64-bit
https://git.pengutronix.de/cgit/barebox/commit/?id=6866796d1ce0 (link may not be stable)
[2/2] i2c: efi: use DIV_ROUND_UP_ULL instead of native division
https://git.pengutronix.de/cgit/barebox/commit/?id=2c24ed8454a0 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-08-20 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 6:56 Ahmad Fatoum
2024-08-15 6:56 ` [PATCH 2/2] i2c: efi: use DIV_ROUND_UP_ULL instead of native division Ahmad Fatoum
2024-08-20 5:28 ` Tomas Marek
2024-08-20 12:07 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172415567436.4005446.11474985151638230302.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox