mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] partitions: dos: prefix hex sector numbers with 0x
@ 2024-08-28 14:10 Bastian Krause
  2024-09-02  7:59 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Bastian Krause @ 2024-08-28 14:10 UTC (permalink / raw)
  To: barebox; +Cc: Bastian Krause

The sector numbers are logged in hexadecimal format. This might not be
immediately clear, so prefix the numbers with 0x.

Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
 common/partitions/dos.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/partitions/dos.c b/common/partitions/dos.c
index 8e4edd885bf..1e3317a6697 100644
--- a/common/partitions/dos.c
+++ b/common/partitions/dos.c
@@ -134,7 +134,7 @@ static void dos_extended_partition(struct block_device *blk, struct dos_partitio
 	while (1) {
 		int rc, i;
 
-		dev_dbg(blk->dev, "expect EBR in sector %x\n", ebr_sector);
+		dev_dbg(blk->dev, "expect EBR in sector 0x%x\n", ebr_sector);
 
 		rc = block_read(blk, buf, ebr_sector, 1);
 		if (rc != 0) {
@@ -144,7 +144,7 @@ static void dos_extended_partition(struct block_device *blk, struct dos_partitio
 
 		/* sanity checks */
 		if (buf[0x1fe] != 0x55 || buf[0x1ff] != 0xaa) {
-			dev_err(blk->dev, "sector %x doesn't contain an EBR signature\n", ebr_sector);
+			dev_err(blk->dev, "sector 0x%x doesn't contain an EBR signature\n", ebr_sector);
 			goto out;
 		}
 
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] partitions: dos: prefix hex sector numbers with 0x
  2024-08-28 14:10 [PATCH] partitions: dos: prefix hex sector numbers with 0x Bastian Krause
@ 2024-09-02  7:59 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-09-02  7:59 UTC (permalink / raw)
  To: barebox, Bastian Krause


On Wed, 28 Aug 2024 16:10:15 +0200, Bastian Krause wrote:
> The sector numbers are logged in hexadecimal format. This might not be
> immediately clear, so prefix the numbers with 0x.
> 
> 

Applied, thanks!

[1/1] partitions: dos: prefix hex sector numbers with 0x
      https://git.pengutronix.de/cgit/barebox/commit/?id=f9dc2964a51f (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-02  7:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-28 14:10 [PATCH] partitions: dos: prefix hex sector numbers with 0x Bastian Krause
2024-09-02  7:59 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox