mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] wd_core: remove obsolete watchdog list
@ 2024-09-18 13:45 Jonas Rebmann
  2024-09-19  6:45 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Jonas Rebmann @ 2024-09-18 13:45 UTC (permalink / raw)
  To: Sascha Hauer, open list:BAREBOX; +Cc: Jonas Rebmann

this patch fixes a null pointer derefence on imx28 related to the
incomplete removal of the watchdog list in 061e10.

Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
---
 drivers/watchdog/wd_core.c | 1 -
 include/watchdog.h         | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/watchdog/wd_core.c b/drivers/watchdog/wd_core.c
index adb4c63909..d4de213fa5 100644
--- a/drivers/watchdog/wd_core.c
+++ b/drivers/watchdog/wd_core.c
@@ -237,7 +237,6 @@ int watchdog_deregister(struct watchdog *wd)
 	}
 
 	class_remove_device(&watchdog_class, &wd->dev);
-	list_del(&wd->list);
 
 	return 0;
 }
diff --git a/include/watchdog.h b/include/watchdog.h
index 2a0e9d1b41..eaea07910c 100644
--- a/include/watchdog.h
+++ b/include/watchdog.h
@@ -28,7 +28,6 @@ struct watchdog {
 	uint64_t last_ping;
 	int seconds_to_expire;
 	struct poller_async poller;
-	struct list_head list;
 	int running; /* enum wdog_hw_running */
 };
 

---
base-commit: 894166924badc0dea06c96476fb86f186e03c779
change-id: 20240918-jre-remove-watchdog-list-76667d3c3b26

Best regards,
-- 
Jonas Rebmann <jre@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] wd_core: remove obsolete watchdog list
  2024-09-18 13:45 [PATCH] wd_core: remove obsolete watchdog list Jonas Rebmann
@ 2024-09-19  6:45 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-09-19  6:45 UTC (permalink / raw)
  To: open list:BAREBOX, Jonas Rebmann


On Wed, 18 Sep 2024 15:45:31 +0200, Jonas Rebmann wrote:
> this patch fixes a null pointer derefence on imx28 related to the
> incomplete removal of the watchdog list in 061e10.
> 
> 

Applied, thanks!

[1/1] wd_core: remove obsolete watchdog list
      https://git.pengutronix.de/cgit/barebox/commit/?id=419ea9350aa0 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-19  6:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-18 13:45 [PATCH] wd_core: remove obsolete watchdog list Jonas Rebmann
2024-09-19  6:45 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox