From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] uimage: use read_full where appropriate
Date: Mon, 14 Oct 2024 14:59:41 +0200 [thread overview]
Message-ID: <172891078193.713955.3145015786372583432.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20241002163621.2458659-1-a.fatoum@pengutronix.de>
On Wed, 02 Oct 2024 18:36:21 +0200, Ahmad Fatoum wrote:
> Apart from the CRC code, where it's no problem to just compute the CRC
> of the last read and read again, all other instances of read() in the
> uimage code are written with the assumption that the read will not be
> short.
>
> Use read_full to satisfy this assumption.
>
> [...]
Applied, thanks!
[1/1] uimage: use read_full where appropriate
https://git.pengutronix.de/cgit/barebox/commit/?id=a77f55e34932 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-10-14 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 16:36 Ahmad Fatoum
2024-10-14 12:59 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172891078193.713955.3145015786372583432.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox