* [PATCH] include: Include <linux/math.h> to resolve implicit declaration of do_div()
@ 2024-10-16 23:47 Abdelrahman Youssef via B4 Relay
2024-10-17 6:02 ` Ahmad Fatoum
2024-10-18 8:55 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Abdelrahman Youssef via B4 Relay @ 2024-10-16 23:47 UTC (permalink / raw)
To: Sascha Hauer, BAREBOX, a.fatoum; +Cc: Abdelrahman Youssef
From: Abdelrahman Youssef <abdelrahmanyossef12@gmail.com>
I was testing barebox with randconfig, so I got a warning (treated as an error) : implicit declaration of do_div().
So <linux/math.h> needs to included.
Signed-off-by: Abdelrahman Youssef <abdelrahmanyossef12@gmail.com>
---
include/linux/ktime.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/ktime.h b/include/linux/ktime.h
index ea368b8802..2b9a91d540 100644
--- a/include/linux/ktime.h
+++ b/include/linux/ktime.h
@@ -21,6 +21,7 @@
#ifndef _LINUX_KTIME_H
#define _LINUX_KTIME_H
+#include <linux/math.h>
#include <linux/time.h>
#include <clock.h>
#include <linux/bug.h>
---
base-commit: 9d47ff66c3892c5a6ddd4704993365a797fbeb68
change-id: 20241017-errors_fixes-81248755b864
Best regards,
--
Abdelrahman Youssef <abdelrahmanyossef12@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] include: Include <linux/math.h> to resolve implicit declaration of do_div()
2024-10-16 23:47 [PATCH] include: Include <linux/math.h> to resolve implicit declaration of do_div() Abdelrahman Youssef via B4 Relay
@ 2024-10-17 6:02 ` Ahmad Fatoum
2024-10-18 8:55 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2024-10-17 6:02 UTC (permalink / raw)
To: abdelrahmanyossef12, Sascha Hauer, BAREBOX, a.fatoum
On 17.10.24 01:47, Abdelrahman Youssef via B4 Relay wrote:
> From: Abdelrahman Youssef <abdelrahmanyossef12@gmail.com>
>
> I was testing barebox with randconfig, so I got a warning (treated as an error) : implicit declaration of do_div().
> So <linux/math.h> needs to included.
>
> Signed-off-by: Abdelrahman Youssef <abdelrahmanyossef12@gmail.com>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Thanks,
Ahmad
> ---
> include/linux/ktime.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/ktime.h b/include/linux/ktime.h
> index ea368b8802..2b9a91d540 100644
> --- a/include/linux/ktime.h
> +++ b/include/linux/ktime.h
> @@ -21,6 +21,7 @@
> #ifndef _LINUX_KTIME_H
> #define _LINUX_KTIME_H
>
> +#include <linux/math.h>
> #include <linux/time.h>
> #include <clock.h>
> #include <linux/bug.h>
>
> ---
> base-commit: 9d47ff66c3892c5a6ddd4704993365a797fbeb68
> change-id: 20241017-errors_fixes-81248755b864
>
> Best regards,
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] include: Include <linux/math.h> to resolve implicit declaration of do_div()
2024-10-16 23:47 [PATCH] include: Include <linux/math.h> to resolve implicit declaration of do_div() Abdelrahman Youssef via B4 Relay
2024-10-17 6:02 ` Ahmad Fatoum
@ 2024-10-18 8:55 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2024-10-18 8:55 UTC (permalink / raw)
To: BAREBOX, a.fatoum, Abdelrahman Youssef via B4 Relay; +Cc: Abdelrahman Youssef
On Thu, 17 Oct 2024 02:47:04 +0300, Abdelrahman Youssef via B4 Relay wrote:
> I was testing barebox with randconfig, so I got a warning (treated as an error) : implicit declaration of do_div().
> So <linux/math.h> needs to included.
>
>
Applied, thanks!
[1/1] include: Include <linux/math.h> to resolve implicit declaration of do_div()
https://git.pengutronix.de/cgit/barebox/commit/?id=cb8767765854 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-18 9:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-16 23:47 [PATCH] include: Include <linux/math.h> to resolve implicit declaration of do_div() Abdelrahman Youssef via B4 Relay
2024-10-17 6:02 ` Ahmad Fatoum
2024-10-18 8:55 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox