mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] lib: lz4: use lz4 instead of lz4c
@ 2024-11-06 17:25 Justin Bronder
  2024-11-07  9:44 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Justin Bronder @ 2024-11-06 17:25 UTC (permalink / raw)
  To: barebox; +Cc: Justin Bronder

lz4c has been considered deprecated by upstream since at least 2018 [1]
and has been disabled by default recently [2].  openSUSE Tumbleweed is
no longer packaging the deprecated version and others will likely
follow.

Going back as far as Ubuntu 16.04/Fedora 25, both lz4 and lz4c are
installed as part of the same package so switching should be safe.

1. https://github.com/lz4/lz4/pull/553
2. https://github.com/lz4/lz4/pull/1479

Signed-off-by: Justin Bronder <jsbronder@cold-front.org>
---
 scripts/Makefile.lib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 1881e3c1..1052bcee 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -492,7 +492,7 @@ cmd_lzo = (cat $(filter-out FORCE,$^) | \
 
 quiet_cmd_lz4 = LZ4     $@
 cmd_lz4 = (cat $(filter-out FORCE,$^) | \
-	lz4c -l -c1 stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
+	lz4 -l --best stdin stdout && $(call size_append, $(filter-out FORCE,$^))) > $@ || \
 	(rm -f $@ ; false)
 
 %.lz4: %
-- 
2.46.1




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] lib: lz4: use lz4 instead of lz4c
  2024-11-06 17:25 [PATCH] lib: lz4: use lz4 instead of lz4c Justin Bronder
@ 2024-11-07  9:44 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-11-07  9:44 UTC (permalink / raw)
  To: barebox, Justin Bronder


On Wed, 06 Nov 2024 12:25:21 -0500, Justin Bronder wrote:
> lz4c has been considered deprecated by upstream since at least 2018 [1]
> and has been disabled by default recently [2].  openSUSE Tumbleweed is
> no longer packaging the deprecated version and others will likely
> follow.
> 
> Going back as far as Ubuntu 16.04/Fedora 25, both lz4 and lz4c are
> installed as part of the same package so switching should be safe.
> 
> [...]

Applied, thanks!

[1/1] lib: lz4: use lz4 instead of lz4c
      https://git.pengutronix.de/cgit/barebox/commit/?id=2a29c0606150 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-07  9:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-06 17:25 [PATCH] lib: lz4: use lz4 instead of lz4c Justin Bronder
2024-11-07  9:44 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox