* [PATCH] ARM: dts: i.MX8MP: disable NPU node if hardware is missing
@ 2024-11-08 10:57 Holger Assmann
2024-11-08 11:43 ` Ahmad Fatoum
2024-11-12 9:18 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Holger Assmann @ 2024-11-08 10:57 UTC (permalink / raw)
To: barebox; +Cc: Holger Assmann
Besides its power domain, the NPU node itself also needs to be disabled
in the kernel device tree if no respective hardware is present at the
SoC.
The power domain has already been dealt with by upstream commit
924101c81d6e ("ARM: i.MX8MP: add feature controller support for Plus").
This patch adds the necessary entry for the NPU node.
Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
---
arch/arm/dts/imx8mp.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/dts/imx8mp.dtsi b/arch/arm/dts/imx8mp.dtsi
index 4d1f1bf588..1604fa13a5 100644
--- a/arch/arm/dts/imx8mp.dtsi
+++ b/arch/arm/dts/imx8mp.dtsi
@@ -99,6 +99,10 @@ &vpumix_blk_ctrl {
barebox,feature-gates = <&feat IMX8M_FEAT_VPU>;
};
+&npu {
+ barebox,feature-gates = <&feat IMX8M_FEAT_NPU>;
+};
+
&pgc_mlmix {
barebox,feature-gates = <&feat IMX8M_FEAT_NPU>;
};
--
2.39.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: i.MX8MP: disable NPU node if hardware is missing
2024-11-08 10:57 [PATCH] ARM: dts: i.MX8MP: disable NPU node if hardware is missing Holger Assmann
@ 2024-11-08 11:43 ` Ahmad Fatoum
2024-11-12 9:18 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2024-11-08 11:43 UTC (permalink / raw)
To: Holger Assmann, barebox
Hello Holger,
Thanks for your fix.
On 08.11.24 11:57, Holger Assmann wrote:
> Besides its power domain, the NPU node itself also needs to be disabled
> in the kernel device tree if no respective hardware is present at the
> SoC.
>
> The power domain has already been dealt with by upstream commit
> 924101c81d6e ("ARM: i.MX8MP: add feature controller support for Plus").
> This patch adds the necessary entry for the NPU node.
> > Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de
Cheers,
Ahmad
> ---
> arch/arm/dts/imx8mp.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/imx8mp.dtsi b/arch/arm/dts/imx8mp.dtsi
> index 4d1f1bf588..1604fa13a5 100644
> --- a/arch/arm/dts/imx8mp.dtsi
> +++ b/arch/arm/dts/imx8mp.dtsi
> @@ -99,6 +99,10 @@ &vpumix_blk_ctrl {
> barebox,feature-gates = <&feat IMX8M_FEAT_VPU>;
> };
>
> +&npu {
> + barebox,feature-gates = <&feat IMX8M_FEAT_NPU>;
> +};
> +
> &pgc_mlmix {
> barebox,feature-gates = <&feat IMX8M_FEAT_NPU>;
> };
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: i.MX8MP: disable NPU node if hardware is missing
2024-11-08 10:57 [PATCH] ARM: dts: i.MX8MP: disable NPU node if hardware is missing Holger Assmann
2024-11-08 11:43 ` Ahmad Fatoum
@ 2024-11-12 9:18 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2024-11-12 9:18 UTC (permalink / raw)
To: barebox, Holger Assmann
On Fri, 08 Nov 2024 11:57:51 +0100, Holger Assmann wrote:
> Besides its power domain, the NPU node itself also needs to be disabled
> in the kernel device tree if no respective hardware is present at the
> SoC.
>
> The power domain has already been dealt with by upstream commit
> 924101c81d6e ("ARM: i.MX8MP: add feature controller support for Plus").
> This patch adds the necessary entry for the NPU node.
>
> [...]
Applied, thanks!
[1/1] ARM: dts: i.MX8MP: disable NPU node if hardware is missing
https://git.pengutronix.de/cgit/barebox/commit/?id=a93c184fb15c (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-12 9:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-08 10:57 [PATCH] ARM: dts: i.MX8MP: disable NPU node if hardware is missing Holger Assmann
2024-11-08 11:43 ` Ahmad Fatoum
2024-11-12 9:18 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox