* [PATCH] kbuild: Use uname for BAREBOX_COMPILE_HOST
@ 2025-02-01 3:59 David Dgien via B4 Relay
2025-02-03 9:18 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: David Dgien via B4 Relay @ 2025-02-01 3:59 UTC (permalink / raw)
To: Sascha Hauer, BAREBOX; +Cc: David Dgien
From: David Dgien <dgienda125@gmail.com>
Adoption of Linux Commit:
| commit 1e66d50ad3a1dbf0169b14d502be59a4b1213149
| Author: Chris Down <chris@chrisdown.name>
| Date: Tue Oct 20 10:34:59 2020 +0100
|
| kbuild: Use uname for LINUX_COMPILE_HOST detection
|
| `hostname` may not be present on some systems as it's not mandated by
| POSIX/SUSv4. This isn't just a theoretical problem: on Arch Linux,
| `hostname` is provided by `inetutils`, which isn't part of the base
| distribution.
|
| ./scripts/mkcompile_h: line 38: hostname: command not found
|
| Use `uname -n` instead, which is more likely to be available (and
| mandated by standards).
|
| Signed-off-by: Chris Down <chris@chrisdown.name>
| Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: David Dgien <dgienda125@gmail.com>
---
scripts/mkcompile_h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/mkcompile_h b/scripts/mkcompile_h
index 49aadc153d44995c23ccc5bc604c2370384387ae..0cc6aa8f0585767435fc6c8537b878925a81a691 100755
--- a/scripts/mkcompile_h
+++ b/scripts/mkcompile_h
@@ -46,7 +46,7 @@ else
BAREBOX_COMPILE_BY=$KBUILD_BUILD_USER
fi
if test -z "$KBUILD_BUILD_HOST"; then
- BAREBOX_COMPILE_HOST=`hostname`
+ BAREBOX_COMPILE_HOST=`uname -n`
else
BAREBOX_COMPILE_HOST=$KBUILD_BUILD_HOST
fi
---
base-commit: b2a15c383ddc4f31792e48e395a425e5c3658dd1
change-id: 20250131-hostname-fix-5171778dd905
Best regards,
--
David Dgien <dgienda125@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: Use uname for BAREBOX_COMPILE_HOST
2025-02-01 3:59 [PATCH] kbuild: Use uname for BAREBOX_COMPILE_HOST David Dgien via B4 Relay
@ 2025-02-03 9:18 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-02-03 9:18 UTC (permalink / raw)
To: BAREBOX, David Dgien
On Fri, 31 Jan 2025 22:59:08 -0500, David Dgien wrote:
> Adoption of Linux Commit:
>
> | commit 1e66d50ad3a1dbf0169b14d502be59a4b1213149
> | Author: Chris Down <chris@chrisdown.name>
> | Date: Tue Oct 20 10:34:59 2020 +0100
> |
> | kbuild: Use uname for LINUX_COMPILE_HOST detection
> |
> | `hostname` may not be present on some systems as it's not mandated by
> | POSIX/SUSv4. This isn't just a theoretical problem: on Arch Linux,
> | `hostname` is provided by `inetutils`, which isn't part of the base
> | distribution.
> |
> | ./scripts/mkcompile_h: line 38: hostname: command not found
> |
> | Use `uname -n` instead, which is more likely to be available (and
> | mandated by standards).
> |
> | Signed-off-by: Chris Down <chris@chrisdown.name>
> | Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> [...]
Applied, thanks!
[1/1] kbuild: Use uname for BAREBOX_COMPILE_HOST
https://git.pengutronix.de/cgit/barebox/commit/?id=b001dfee2bd0 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-03 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-01 3:59 [PATCH] kbuild: Use uname for BAREBOX_COMPILE_HOST David Dgien via B4 Relay
2025-02-03 9:18 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox