* [PATCH] mfd: rn5t568: add priority to reset_source_set_device()
@ 2025-03-03 14:31 Bastian Krause
2025-03-03 14:44 ` Ahmad Fatoum
2025-03-04 8:15 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Bastian Krause @ 2025-03-03 14:31 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum, Bastian Krause
30322f4b565 ("reset_source: give reset_source_set_device a priority
parameter") introduced a reset source priority parameter, but forgot
applying a priority the Ricoh RN5T568 PMIC driver's
reset_source_set_device() call.
So apply the default priority 200 here, too.
Fixes this build error:
drivers/mfd/rn5t568.c: In function 'rn5t568_reset_reason_detect':
drivers/mfd/rn5t568.c:82:9: error: too few arguments to function 'reset_source_set_device'
82 | reset_source_set_device(dev, type);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/mfd/rn5t568.c:17:
include/reset_source.h:31:6: note: declared here
31 | void reset_source_set_device(struct device *dev, enum reset_src_type st,
| ^~~~~~~~~~~~~~~~~~~~~~~
Fixes: 30322f4b565 ("reset_source: give reset_source_set_device a priority parameter")
Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
drivers/mfd/rn5t568.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/rn5t568.c b/drivers/mfd/rn5t568.c
index 7468338a2d5..e140cea03b0 100644
--- a/drivers/mfd/rn5t568.c
+++ b/drivers/mfd/rn5t568.c
@@ -79,7 +79,7 @@ static int rn5t568_reset_reason_detect(struct device *dev,
return -EINVAL;
}
- reset_source_set_device(dev, type);
+ reset_source_set_device(dev, type, 200);
return 0;
}
--
2.39.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: rn5t568: add priority to reset_source_set_device()
2025-03-03 14:31 [PATCH] mfd: rn5t568: add priority to reset_source_set_device() Bastian Krause
@ 2025-03-03 14:44 ` Ahmad Fatoum
2025-03-04 8:15 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2025-03-03 14:44 UTC (permalink / raw)
To: Bastian Krause, barebox
Hello Bastian,
On 03.03.25 15:31, Bastian Krause wrote:
> 30322f4b565 ("reset_source: give reset_source_set_device a priority
> parameter") introduced a reset source priority parameter, but forgot
> applying a priority the Ricoh RN5T568 PMIC driver's
> reset_source_set_device() call.
>
> So apply the default priority 200 here, too.
>
> Fixes this build error:
>
> drivers/mfd/rn5t568.c: In function 'rn5t568_reset_reason_detect':
> drivers/mfd/rn5t568.c:82:9: error: too few arguments to function 'reset_source_set_device'
> 82 | reset_source_set_device(dev, type);
> | ^~~~~~~~~~~~~~~~~~~~~~~
> In file included from drivers/mfd/rn5t568.c:17:
> include/reset_source.h:31:6: note: declared here
> 31 | void reset_source_set_device(struct device *dev, enum reset_src_type st,
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 30322f4b565 ("reset_source: give reset_source_set_device a priority parameter")
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
Ouch, sorry for missing the follow-up commit fixing this.
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
We should probably add an allyes build to CI.
Cheers,
Ahmad
> ---
> drivers/mfd/rn5t568.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/rn5t568.c b/drivers/mfd/rn5t568.c
> index 7468338a2d5..e140cea03b0 100644
> --- a/drivers/mfd/rn5t568.c
> +++ b/drivers/mfd/rn5t568.c
> @@ -79,7 +79,7 @@ static int rn5t568_reset_reason_detect(struct device *dev,
> return -EINVAL;
> }
>
> - reset_source_set_device(dev, type);
> + reset_source_set_device(dev, type, 200);
> return 0;
> }
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: rn5t568: add priority to reset_source_set_device()
2025-03-03 14:31 [PATCH] mfd: rn5t568: add priority to reset_source_set_device() Bastian Krause
2025-03-03 14:44 ` Ahmad Fatoum
@ 2025-03-04 8:15 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2025-03-04 8:15 UTC (permalink / raw)
To: barebox, Bastian Krause; +Cc: Ahmad Fatoum
On Mon, 03 Mar 2025 15:31:44 +0100, Bastian Krause wrote:
> 30322f4b565 ("reset_source: give reset_source_set_device a priority
> parameter") introduced a reset source priority parameter, but forgot
> applying a priority the Ricoh RN5T568 PMIC driver's
> reset_source_set_device() call.
>
> So apply the default priority 200 here, too.
>
> [...]
Applied, thanks!
[1/1] mfd: rn5t568: add priority to reset_source_set_device()
https://git.pengutronix.de/cgit/barebox/commit/?id=af8e7ff8a5c5 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-04 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-03 14:31 [PATCH] mfd: rn5t568: add priority to reset_source_set_device() Bastian Krause
2025-03-03 14:44 ` Ahmad Fatoum
2025-03-04 8:15 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox