mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] ci: coverity: fix git hash truncation to 10 characters
@ 2025-03-21 10:12 Ahmad Fatoum
  2025-03-24  8:44 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-03-21 10:12 UTC (permalink / raw)
  To: barebox; +Cc: jre, Ahmad Fatoum

A misplaced $ lead to versions looking like this:

  Version: 2025.02.0-g\{84a1605196530ff77...

instead of

  Version: 2025.02.0-g84a1605196

Move it to fix.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Untested, but looks straight-forward enough.
---
 .github/workflows/coverity.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/coverity.sh b/.github/workflows/coverity.sh
index 1fd7dd068275..ee4a481503c7 100755
--- a/.github/workflows/coverity.sh
+++ b/.github/workflows/coverity.sh
@@ -33,7 +33,7 @@ function run_coverity {
     tool_dir=$(find "$COVERITY_SCAN_TOOL_BASE" -type d -name 'cov-analysis*')
     results_archive="analysis-results.tgz"
 
-    version="$(make bareboxversion)-g{$GITHUB_SHA:0:10}"
+    version="$(make bareboxversion)-g${GITHUB_SHA:0:10}"
 
     make ARCH=sandbox sandbox_defconfig
     COVERITY_UNSUPPORTED=1 "$tool_dir/bin/cov-build" --dir "$results_dir" sh -c "make -j$(nproc) ARCH=sandbox"
-- 
2.39.5




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] ci: coverity: fix git hash truncation to 10 characters
  2025-03-21 10:12 [PATCH master] ci: coverity: fix git hash truncation to 10 characters Ahmad Fatoum
@ 2025-03-24  8:44 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-03-24  8:44 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum; +Cc: jre


On Fri, 21 Mar 2025 11:12:18 +0100, Ahmad Fatoum wrote:
> A misplaced $ lead to versions looking like this:
> 
>   Version: 2025.02.0-g\{84a1605196530ff77...
> 
> instead of
> 
>   Version: 2025.02.0-g84a1605196
> 
> [...]

Applied, thanks!

[1/1] ci: coverity: fix git hash truncation to 10 characters
      https://git.pengutronix.de/cgit/barebox/commit/?id=c683c1eca2b2 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-03-24  8:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-21 10:12 [PATCH master] ci: coverity: fix git hash truncation to 10 characters Ahmad Fatoum
2025-03-24  8:44 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox