* [PATCH master] lib: select HAS_INSECURE_DEFAULTS from ALLOW_PRNG_FALLBACK
@ 2025-04-17 6:23 Ahmad Fatoum
2025-04-22 8:24 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-04-17 6:23 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
PRNG fallback inside get_crypto_bytes is only useful for debugging
and a really bad idea in production. We already warn about this at
runtime, but let's make sure it's directly evident in the config as
well.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
lib/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/Kconfig b/lib/Kconfig
index 8e1d8086fbb6..0cb3a136b38e 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -139,6 +139,7 @@ config RATP
config ALLOW_PRNG_FALLBACK
bool "Allow fallback to PRNG if HWRNG not available."
+ select HAS_INSECURE_DEFAULTS
help
WARNING: it is not secure!!
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH master] lib: select HAS_INSECURE_DEFAULTS from ALLOW_PRNG_FALLBACK
2025-04-17 6:23 [PATCH master] lib: select HAS_INSECURE_DEFAULTS from ALLOW_PRNG_FALLBACK Ahmad Fatoum
@ 2025-04-22 8:24 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-04-22 8:24 UTC (permalink / raw)
To: barebox, Ahmad Fatoum
On Thu, 17 Apr 2025 08:23:49 +0200, Ahmad Fatoum wrote:
> PRNG fallback inside get_crypto_bytes is only useful for debugging
> and a really bad idea in production. We already warn about this at
> runtime, but let's make sure it's directly evident in the config as
> well.
>
>
Applied, thanks!
[1/1] lib: select HAS_INSECURE_DEFAULTS from ALLOW_PRNG_FALLBACK
https://git.pengutronix.de/cgit/barebox/commit/?id=5d82702f48ec (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-22 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-17 6:23 [PATCH master] lib: select HAS_INSECURE_DEFAULTS from ALLOW_PRNG_FALLBACK Ahmad Fatoum
2025-04-22 8:24 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox