From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH master] font: fbconsole: fix underflow when printing non-ASCII characters
Date: Tue, 22 Apr 2025 14:15:44 +0200 [thread overview]
Message-ID: <174532414477.3582743.9088291885765402251.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20250422053641.3435585-1-a.fatoum@pengutronix.de>
On Tue, 22 Apr 2025 07:36:41 +0200, Ahmad Fatoum wrote:
> With signed characters, non-ASCII characters (i.e. valued >= 128)
> are negative and remain so when casted to int.
>
> find_font_index will thus multiply the index with a negative number and
> look for font data before the actual start of the font.
>
> A cast to unsigned fixes this, because all fonts that trigger this if
> clause's branch have 256 characters.
>
> [...]
Applied, thanks!
[1/1] font: fbconsole: fix underflow when printing non-ASCII characters
https://git.pengutronix.de/cgit/barebox/commit/?id=fbf4d8e13976 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2025-04-22 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 5:36 Ahmad Fatoum
2025-04-22 12:15 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174532414477.3582743.9088291885765402251.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox