From mboxrd@z Thu Jan 1 00:00:00 1970
Delivery-date: Tue, 22 Apr 2025 15:18:29 +0200
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
(Exim 4.96)
(envelope-from <barebox-bounces+lore=pengutronix.de@lists.infradead.org>)
id 1u7DW9-0044FI-35
for lore@lore.pengutronix.de;
Tue, 22 Apr 2025 15:18:29 +0200
Received: from bombadil.infradead.org ([2607:7c80:54:3::133])
by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92)
(envelope-from <barebox-bounces+lore=pengutronix.de@lists.infradead.org>)
id 1u7DW9-0001W3-Dm
for lore@pengutronix.de; Tue, 22 Apr 2025 15:18:29 +0200
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help
:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding:
Content-Type:MIME-Version:Date:Message-Id:Subject:References:In-Reply-To:To:
From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
bh=U1e8ICgS25OCQc9vC6NCr6yEwL+XoLDUiaTacnJ+0pw=; b=WTdK1gloJjVGcGE369nse7bV5e
haud5Zmjhy/5EGEiEWsyGJWXFfHtz116HtDyx+Bj1c0RfeyMidy1VDHfT5Owlkt3BU7V2UAjNxPHo
SgCWkBxB01Zpchb2KbsBBLqazBFRpQJ72xrKnJOOi6QpHKoP3E0MOH0shPwOzPsZuRx8xHUT5+V7z
73lOzFNYXKlHPN8wghU5w2CgJg+DW2Gtquz5NEFCrSLnYXrrcESlRaeq9t6Eq2r2hlk9M491CmTsw
7nu9acm67/KIMXst0e0543WDoZJrPKRbDY0wTRk+QAIra9dU+wMI5nlMOv74xvWuLNoxXdclew9M5
mbxYqGEw==;
Received: from localhost ([::1] helo=bombadil.infradead.org)
by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))
id 1u7DVc-00000007GOR-3nkW;
Tue, 22 Apr 2025 13:17:57 +0000
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))
id 1u7CXS-000000074W0-2B4O
for barebox@lists.infradead.org;
Tue, 22 Apr 2025 12:15:47 +0000
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92)
(envelope-from <s.hauer@pengutronix.de>)
id 1u7CXR-00063C-1f; Tue, 22 Apr 2025 14:15:45 +0200
Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28])
by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
(Exim 4.96)
(envelope-from <s.hauer@pengutronix.de>)
id 1u7CXQ-001Y9y-2j;
Tue, 22 Apr 2025 14:15:44 +0200
Received: from localhost ([::1] helo=dude02.red.stw.pengutronix.de)
by dude02.red.stw.pengutronix.de with esmtp (Exim 4.96)
(envelope-from <s.hauer@pengutronix.de>)
id 1u7CXQ-00F22o-2V;
Tue, 22 Apr 2025 14:15:44 +0200
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
In-Reply-To: <20250422053641.3435585-1-a.fatoum@pengutronix.de>
References: <20250422053641.3435585-1-a.fatoum@pengutronix.de>
Message-Id: <174532414477.3582743.9088291885765402251.b4-ty@pengutronix.de>
Date: Tue, 22 Apr 2025 14:15:44 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Mailer: b4 0.12.3
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3
X-CRM114-CacheID: sfid-20250422_051546_563965_E5C33013
X-CRM114-Status: UNSURE ( 7.75 )
X-CRM114-Notice: Please train this message.
X-BeenThere: barebox@lists.infradead.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: <barebox.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/barebox>,
<mailto:barebox-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/barebox/>
List-Post: <mailto:barebox@lists.infradead.org>
List-Help: <mailto:barebox-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/barebox>,
<mailto:barebox-request@lists.infradead.org?subject=subscribe>
Sender: "barebox" <barebox-bounces@lists.infradead.org>
X-SA-Exim-Connect-IP: 2607:7c80:54:3::133
X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
metis.whiteo.stw.pengutronix.de
X-Spam-Level:
X-Spam-Status: No, score=-5.4 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE
autolearn=unavailable autolearn_force=no version=3.4.2
Subject: Re: [PATCH master] font: fbconsole: fix underflow when printing
non-ASCII characters
X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000)
X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de)
On Tue, 22 Apr 2025 07:36:41 +0200, Ahmad Fatoum wrote:
> With signed characters, non-ASCII characters (i.e. valued >= 128)
> are negative and remain so when casted to int.
>
> find_font_index will thus multiply the index with a negative number and
> look for font data before the actual start of the font.
>
> A cast to unsigned fixes this, because all fonts that trigger this if
> clause's branch have 256 characters.
>
> [...]
Applied, thanks!
[1/1] font: fbconsole: fix underflow when printing non-ASCII characters
https://git.pengutronix.de/cgit/barebox/commit/?id=fbf4d8e13976 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>