[PATCH] clocksource: omit seeding of RNG in PBL

[PATCH] clocksource: omit seeding of RNG in PBL

[Ahmad Fatoum]

We do not maintain a PRNG in the PBL, so we should omit the call to
srand_xor in PBL, otherwise it expands to BUG() and breaks the newly
introduced PBL clocksource support.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/clock.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/clock.c b/common/clock.c
index 517116e3b9a3..50941fb00822 100644
--- a/common/clock.c
+++ b/common/clock.c
@@ -228,7 +228,8 @@ int init_clock(struct clocksource *cs)
 	cs->cycle_last = cs->read() & cs->mask;
 	current_clock = cs;
 
-	srand_xor(cs->cycle_last);
+	if (IN_PROPER)
+		srand_xor(cs->cycle_last);
 
 	return 0;
 }
-- 
2.39.5

Re: [PATCH] clocksource: omit seeding of RNG in PBL

[Sascha Hauer]

On Thu, 24 Apr 2025 10:48:33 +0200, Ahmad Fatoum wrote:
> We do not maintain a PRNG in the PBL, so we should omit the call to
> srand_xor in PBL, otherwise it expands to BUG() and breaks the newly
> introduced PBL clocksource support.
> 
> 

Applied, thanks!

[1/1] clocksource: omit seeding of RNG in PBL
      https://git.pengutronix.de/cgit/barebox/commit/?id=a6e031cc425d (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>